Skip to content

Add plato JS static code analysis tool. - #8915

Merged
benpatterson merged 2 commits into
masterfrom
benp/add-plato-jul2015
Dec 8, 2015
Merged

Add plato JS static code analysis tool.#8915
benpatterson merged 2 commits into
masterfrom
benp/add-plato-jul2015

Conversation

@benpatterson

Copy link
Copy Markdown
Contributor

No description provided.

@benpatterson

Copy link
Copy Markdown
Contributor Author

Add the ability to run static code analysis on javascript. No tooling (e.g., paver, build scripts, etc) is included in this commit.

To use plato locally, here is an example command that will produce complexity reports on common/

plato -q -x common/static/js/vendor/ -t common -l .jshintrc -r -d jscomplexity common/static/js/

This produces an index.html with supporting files under jscomplexity/. Also note that it produces *.json files which can be parsed and eventually trended, asserted upon, etc.

Plato on github

@benpatterson

Copy link
Copy Markdown
Contributor Author

@singingwolfboy @jzoldak @andy-armstrong

Thoughts? I can give a brief demo if you'd like. This was a hackathon project. We can add it here as something available in a dev environment for perusal. Nothing to collect or assert at this point; just an added resource.

@andy-armstrong

Copy link
Copy Markdown
Contributor

👍 Seems useful to me. I'm out the rest of the week, but I'd love a quick demo next week.

@singingwolfboy

Copy link
Copy Markdown
Contributor

@benpatterson could you add a short description of how you might use plato in a README file somewhere? Adding a dependency without actually using it seems odd to me. Could be as simple as creating common/static/js/README.txt with the contents of your first comment on your pull request.

@benpatterson
benpatterson force-pushed the benp/add-plato-jul2015 branch from a90bbdf to c41b67f Compare December 1, 2015 19:38
@benpatterson

Copy link
Copy Markdown
Contributor Author

@singingwolfboy thanks for the ping on this. I've added documentation. It's not in the place you suggested, but fits in nicely with all of our quality tools. Thoughts?

@andy-armstrong I'm still good for a demo of this. Perhaps later this week?

@jzoldak

jzoldak commented Dec 8, 2015

Copy link
Copy Markdown
Contributor

LGTM 👍

benpatterson pushed a commit that referenced this pull request Dec 8, 2015
Add plato JS static code analysis tool.
@benpatterson
benpatterson merged commit 2d3a4c9 into master Dec 8, 2015
@benpatterson
benpatterson deleted the benp/add-plato-jul2015 branch January 13, 2016 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants