Re-upgrade to setuptools - #8934
Merged
Merged
Conversation
singingwolfboy
force-pushed
the
db/fix-python-saml-compile-issue
branch
2 times, most recently
from
July 15, 2015 15:18
165dc09 to
d940dfb
Compare
singingwolfboy
changed the title
singingwolfboy
force-pushed
the
db/fix-python-saml-compile-issue
branch
from
July 15, 2015 15:22
d940dfb to
3d8853a
Compare
Contributor
There was a problem hiding this comment.
Nit: You can also mention @edx/devops
Contributor
Author
There was a problem hiding this comment.
I believe that only people in the @edx/devops team are able to mention it. Anyway, this is just copied from the header of requirements/edx/base.txt.
Contributor
|
👍 once we can build AMIs from this without issues. |
singingwolfboy
force-pushed
the
db/fix-python-saml-compile-issue
branch
from
July 22, 2015 14:52
3d8853a to
0567597
Compare
Contributor
Author
|
@feanil: @fredsmith and I were able to successfully build AMIs for the Cypress RC (which contains this PR), deploy those AMIs, and verify that they worked correctly. Is this ready to merge to master? |
Contributor
|
👍 once this is tested on an existing AMI (not from scratch). We should release this the week of Aug 3. |
singingwolfboy
force-pushed
the
db/fix-python-saml-compile-issue
branch
from
July 30, 2015 14:33
0567597 to
88a5fe2
Compare
singingwolfboy
force-pushed
the
db/fix-python-saml-compile-issue
branch
from
July 30, 2015 20:23
88a5fe2 to
afeef4c
Compare
singingwolfboy
added a commit
that referenced
this pull request
Jul 31, 2015
Re-upgrade to setuptools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-introduces setuptools. This was originally done in #8161, reverted in #8933, and is now going back in.
The latest version of setuptools has a bug where installing python-saml before lxml is installed caused setuptools to go into an infinite loop. See reproducible failure and workaround here: https://gist.github.com/singingwolfboy/7f11ffc5b95b4437ba9d