Skip to content

Decorate flaky test TNL-3183 - #9565

Merged
jzoldak merged 1 commit into
masterfrom
zoldak/TNL-3183
Sep 1, 2015
Merged

Decorate flaky test TNL-3183#9565
jzoldak merged 1 commit into
masterfrom
zoldak/TNL-3183

Conversation

@jzoldak

@jzoldak jzoldak commented Sep 1, 2015

Copy link
Copy Markdown
Contributor

@benpatterson

Copy link
Copy Markdown
Contributor

👍

jzoldak pushed a commit that referenced this pull request Sep 1, 2015
Decorate flaky test TNL-3183
@jzoldak
jzoldak merged commit 804e110 into master Sep 1, 2015
@jzoldak
jzoldak deleted the zoldak/TNL-3183 branch September 1, 2015 20:18
@sarina

sarina commented Sep 1, 2015

Copy link
Copy Markdown
Contributor

👍

@jzoldak when tagging people outside the building on pull requests, could you please be a little bit more explicit about why you're tagging them, and what you're expecting the outcome of tagging them to be? Imagine your'e an open source contributor to a project and you get tagged on a sparse PR like this, perhaps unaware of our flaky test infrastructure. What info would help you make sense of this, and understand why you were tagged? I want to be more inclusive here, and that means being significantly less opaque.

@jzoldak

jzoldak commented Sep 1, 2015

Copy link
Copy Markdown
Contributor Author

Ah, great point @sarina.
Sorry about that @mirjamsk and @Colin-Fredericks - I tagged you guys on this PR just so you know, given that the test was introduced in #9464.
The flaky test process is documented here.
I briefly looked at the code to see if I could quickly figure out what was going on with the test, but I don't have time to really troubleshoot it and submit a fix. Here's the JIRA ticket that I submitted to the TNL backlog.
If either of you guys wanted to pick it up that would be great. Otherwise it will most likely languish there until someone else does. In the meantime, the flaky decorator will only make the test run twice if it fails. If it passes the second time it will be considered passing. If it fails the 2nd time it will be considered failing.

@mirjamsk mirjamsk mentioned this pull request Sep 2, 2015
@mirjamsk

mirjamsk commented Sep 2, 2015

Copy link
Copy Markdown
Contributor

@jzoldak, @sarina here's a pull request that addresses this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants