Skip to content

Mention import linter for api.py in OEP-49 - #467

Merged
bradenmacdonald merged 1 commit into
masterfrom
bradenmacdonald/oep-49-import-linter
Apr 26, 2023
Merged

Mention import linter for api.py in OEP-49#467
bradenmacdonald merged 1 commit into
masterfrom
bradenmacdonald/oep-49-import-linter

Conversation

@bradenmacdonald

Copy link
Copy Markdown
Contributor

We now have a tool for enforcing OEP-49 compliant usage of api.py for Django apps. This updates the OEP to raise awareness of the new linter and encourage broader usage.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@robrap robrap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a changelog entry?

@bradenmacdonald
bradenmacdonald force-pushed the bradenmacdonald/oep-49-import-linter branch from 289b5e7 to 08fc8e9 Compare April 20, 2023 22:05
@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

@robrap Right, thanks. Done!

@itsjeyd

itsjeyd commented Apr 26, 2023

Copy link
Copy Markdown

label: core contributor

@github-actions github-actions Bot added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Apr 26, 2023
@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

Haven't gotten any other feedback or objections here so I'm going to merge for now :) Thanks @robrap for the review.

@bradenmacdonald
bradenmacdonald merged commit 35566a9 into master Apr 26, 2023
@bradenmacdonald
bradenmacdonald deleted the bradenmacdonald/oep-49-import-linter branch April 26, 2023 17:45
@openedx-webhooks

Copy link
Copy Markdown

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants