Skip to content

feat! Turn off survey link for merged/closed PRs #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdmccormick merged 2 commits into from
Aug 27, 2024
Merged

feat! Turn off survey link for merged/closed PRs #299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f2b0ea
feat! Turn off survey link for merged/closed PRs
sarina Aug 23, 2024
38e581a
Update openedx_webhooks/tasks/pr_tracking.py
sarina Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions openedx_webhooks/tasks/pr_tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,8 +291,10 @@ def desired_support_state(pr: PrDict) -> PrDesiredInfo:
if state == "reopened":
desired.bot_comments_to_remove.add(BotComment.SURVEY)

if state in ["closed", "merged"]:
desired.bot_comments.add(BotComment.SURVEY)
# # temp: Disable survey link on pull requests
Comment thread
sarina marked this conversation as resolved.
# # https://github.com/openedx/openedx-webhooks/issues/259
# if state in ["closed", "merged"]:
# desired.bot_comments.add(BotComment.SURVEY)

if desired.is_refused and state not in ["closed", "merged"]:
desired.bot_comments.add(BotComment.NO_CONTRIBUTIONS)
Expand Down