Skip to content

Drop py3.8 support | Replace pkg_resources lib with importlib.resources - #350

Merged
farhan merged 1 commit into
masterfrom
farhan/replace_pkg_resources
Aug 7, 2024
Merged

Drop py3.8 support | Replace pkg_resources lib with importlib.resources#350
farhan merged 1 commit into
masterfrom
farhan/replace_pkg_resources

Conversation

@farhan

@farhan farhan commented Feb 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Drop Py3.8 support
  • Replace pkg_resources lib with importlib.resources

Ticket: openedx/XBlock#676

PR is expected to merge after Open edX redwood release

Followed migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html

Testing:
I have tested the changes with following steps:

  1. Use PR of xblock-sdk
  2. Install xblock into xblock-sdk
  3. Install feedback-xblock from PR into xblock-sdk
  4. Test feedback xblock functionality

@farhan farhan linked an issue Feb 16, 2024 that may be closed by this pull request
Switch off of deprecated pkg_resources library openedx/XBlock#676
Closed
@farhan
farhan marked this pull request as ready for review February 16, 2024 09:50
@farhan
farhan marked this pull request as draft February 16, 2024 09:58
@farhan farhan added the blocked by other work PR cannot be finished until other work is complete label May 7, 2024
@farhan
farhan force-pushed the farhan/replace_pkg_resources branch 4 times, most recently from 161b260 to 745e14c Compare May 20, 2024 12:02
@farhan farhan closed this May 20, 2024
@farhan farhan reopened this May 20, 2024
@farhan
farhan marked this pull request as ready for review May 22, 2024 06:01
@farhan farhan mentioned this pull request May 22, 2024
Merged
@farhan
farhan requested review from a team, feanil, irtazaakram, kdmccormick and salman2013 May 23, 2024 07:36
@feanil

feanil commented May 28, 2024

Copy link
Copy Markdown
Contributor

@farhan I think as a part of this PR, we should remove testing for Python 3.8 right? since that will fail to have the importlib module that you're using? As a part of that we should also update the classifiers and do a major version bump.

@farhan
farhan force-pushed the farhan/replace_pkg_resources branch 2 times, most recently from 0dd0900 to 061ffc3 Compare May 30, 2024 07:22
@farhan farhan changed the title Replace pkg resources Drop Py3.8 support | Replace pkg_resources lib with importlib.resources May 30, 2024
@farhan
farhan force-pushed the farhan/replace_pkg_resources branch from 061ffc3 to 2bc4b42 Compare May 30, 2024 07:29
@farhan farhan changed the title Drop Py3.8 support | Replace pkg_resources lib with importlib.resources Drop py3.8 support | Replace pkg_resources lib with importlib.resources May 30, 2024
kdmccormick
kdmccormick reviewed Jun 18, 2024
View reviewed changes

@kdmccormick kdmccormick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm glad to hear that the xblock-sdk is still useful for testing.

Just one change request, looks good otherwise. I have not manually tested but I trust that you have.

Comment thread workbench/__init__.py Outdated
@farhan
farhan force-pushed the farhan/replace_pkg_resources branch from cdd51da to bbbffde Compare June 24, 2024 08:09
@farhan
farhan force-pushed the farhan/replace_pkg_resources branch from bbbffde to 39ff513 Compare July 19, 2024 08:11
@farhan farhan mentioned this pull request Aug 8, 2024
Closed
@CodeWithEmad CodeWithEmad mentioned this pull request Aug 1, 2024
Merged
@feanil

feanil commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

@farhan can you update the commit messages and squash anything that needs to be squashed and then I think we could land this.

@farhan
chore: Drop py3.8 support | Replace pkg_resources lib with importlib.…
805ea25 
…resources

* chore: transitioned from pkg_resources api to importlib-resources api
* feat!: drop support for python 3.8
@farhan
farhan force-pushed the farhan/replace_pkg_resources branch from 0fc1e44 to 805ea25 Compare August 7, 2024 09:48
@farhan
farhan merged commit 088065b into master Aug 7, 2024
@farhan
farhan deleted the farhan/replace_pkg_resources branch August 7, 2024 09:51
@farhan farhan removed the blocked by other work PR cannot be finished until other work is complete label Aug 7, 2024
@farhan

farhan commented Aug 7, 2024

Copy link
Copy Markdown
Contributor Author

@feanil merged.
Should I publish xblock-sdk with 0.12.0 or 1.0.0 ?

kdmccormick
kdmccormick reviewed Aug 7, 2024
View reviewed changes
Comment thread CHANGELOG.rst

These are notable changes in XBlock.

1.0.0 - 2024-05-30

@kdmccormick kdmccormick Aug 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhan The version in workbench/__init__.py is 0.12.0, and that is what matters to PyPI, so everything else should match that. Please fix the changelog to say 0.12.0, and then publish a 0.12.0 release.

@farhan farhan Aug 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdmccormick I have created the PR
My point was we had dropped support of Python 3.8 now which means we should upgrade the major version.
So should we update version to 1.0.0 now or should keep it below 1 yet?

@farhan farhan mentioned this pull request Aug 8, 2024
Merged
@farhan farhan mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdmccormick kdmccormick kdmccormick left review comments
@feanil feanil Awaiting requested review from feanil
@salman2013 salman2013 Awaiting requested review from salman2013
@irtazaakram irtazaakram Awaiting requested review from irtazaakram

Assignees

No one assigned

Labels

None yet

Projects

Aximprovements Team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch off of deprecated pkg_resources library

3 participants

@farhan @feanil @kdmccormick