Skip to content

fix(problem): use CSS logical properties for RTL layout support - #287

Open
andrey-canon wants to merge 1 commit into
openedx:mainfrom
eduNEXT:and/fix-problem-rtl
Open

fix(problem): use CSS logical properties for RTL layout support#287
andrey-canon wants to merge 1 commit into
openedx:mainfrom
eduNEXT:and/fix-problem-rtl

Conversation

@andrey-canon

Copy link
Copy Markdown

Description

This PR fixes alignment and layout issues in Right-to-Left (RTL) languages for the ProblemBlock (xblocks_contrib.problem).

Previously, ProblemBlockDisplay.css used physical directional properties (margin-right, padding-left, left) that forced checkboxes, radio buttons, and labels to remain LTR-aligned even when rendering the platform in RTL languages (such as Arabic).

These physical properties have been replaced with CSS logical properties, allowing the browser to dynamically mirror alignments depending on the text direction (dir="ltr" or dir="rtl").

Changes Made

  • xblocks_contrib/problem/assets/static/css/ProblemBlockDisplay.css:
    • Replaced margin-right with margin-inline-end for choicetextgroup inputs.
    • Replaced padding-left with padding-inline-start for choicegroup labels.
    • Replaced left with inset-inline-start for radio buttons and checkboxes.

How to Test

  1. Checkout this branch

  2. Run npm install in the root directory of xblocks-core:
    npm install

  3. Build the assets:
    npm run build

  4. Go to a course page containing a problem block and verify the layout:

    • English (LTR): Verify that input choices, radio buttons, and labels retain their normal left-to-right alignment.
    • Arabic (RTL): Verify that input choices, radio buttons, and margins correctly mirror to the right side.

Before

EN

image

AR

image

After

EN

image

AR

image

NOTE

The platform contains a bug that doesn't allow to align correctly to see the full version please use this branch https://github.com/eduNEXT/edx-platform/tree/and/fix-problem-rtl
image

Replace physical CSS properties (margin-right, padding-left, left) with
logical properties (margin-inline-end, padding-inline-start, inset-inline-start)
in ProblemBlockDisplay.css to fix choicegroup alignment issues in RTL locales.
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @andrey-canon!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants