-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Old deprecations [note: macOS Makefile randomly fails in this PR] #7667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| #include "ofConstants.h" | ||
| #include "glm/fwd.hpp" | ||
| #include "ofConstants.h" | ||
| #include <deque> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure we need ofConstants included before glm, due to us defining GLM_FORCE_CTOR_INIT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh updated in a commit. but that kind of include order dependency is inherently brittle..
i see there is also a pattern of doing #define GLM_FORCE_CTOR_INIT like e.g.
| #define GLM_FORCE_CTOR_INIT |
but that won't help for instance if a library that uses GLM manages to get included before ofConstants...
how about setting GLM_FORCE_CTOR_INIT with a compile -D?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree we need to do GLM_FORCE_CTOR_INIT in all the project files. But that will be a separate PR and will take a bit of time, so need the above change to be reverted to merge :)
|
curious which part of this is addressing: "macOS Makefile randomly fails" |
|
ah sorry for the ambiguity! it means the tests for this PR here are randomly failing in macOS Makefiles. the last run in a Network test, the previous one in a NodeRegression Test. I cannot reproduce the failures, and the tests are otherwise all passing in other platforms. |
closes #1550 expect for:
(not exactly a deprecation) and
not sure what is the role of that function and if it can simply be removed