Skip to content

Conversation

@artificiel
Copy link
Contributor

closes #1550 expect for:

bool ofDirectory::getShowHidden() can we give this a better name please?

(not exactly a deprecation) and

setCoordHandedness actually does nothing in the cpp file

not sure what is the role of that function and if it can simply be removed

@artificiel artificiel changed the title Old deprecations Old deprecations [macOS Makefile randomly fails] Sep 19, 2023
#include "ofConstants.h"
#include "glm/fwd.hpp"
#include "ofConstants.h"
#include <deque>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure we need ofConstants included before glm, due to us defining GLM_FORCE_CTOR_INIT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh updated in a commit. but that kind of include order dependency is inherently brittle..

i see there is also a pattern of doing #define GLM_FORCE_CTOR_INIT like e.g.

but that won't help for instance if a library that uses GLM manages to get included before ofConstants...

how about setting GLM_FORCE_CTOR_INIT with a compile -D?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree we need to do GLM_FORCE_CTOR_INIT in all the project files. But that will be a separate PR and will take a bit of time, so need the above change to be reverted to merge :)

@ofTheo
Copy link
Member

ofTheo commented Sep 19, 2023

curious which part of this is addressing: "macOS Makefile randomly fails"

@artificiel
Copy link
Contributor Author

ah sorry for the ambiguity! it means the tests for this PR here are randomly failing in macOS Makefiles. the last run in a Network test, the previous one in a NodeRegression Test. I cannot reproduce the failures, and the tests are otherwise all passing in other platforms.

@artificiel artificiel changed the title Old deprecations [macOS Makefile randomly fails] Old deprecations [note: macOS Makefile randomly fails in this PR] Sep 20, 2023
@artificiel artificiel marked this pull request as draft October 31, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group: Deprecated Code

2 participants