remove OF_NO_FMOD #8184
remove OF_NO_FMOD #8184
Conversation
|
Looks awesome!! |
|
I think this one is finally ok! |
| #define OF_CAIRO | ||
| #define OF_RTAUDIO | ||
| #ifndef __MACOSX_CORE__ | ||
| #define __MACOSX_CORE__ // rtAudio |
There was a problem hiding this comment.
Safe to remove even though it mentions rtAudio?
There was a problem hiding this comment.
The define might be worth keeping around for legacy purposes. Removing it doesn't seem like it adds much benefit other than being a bit more tidy.
| HEADER_SSL = $(OF_PATH)/libs/openssl/include | ||
| HEADER_URIPARSER = $(OF_PATH)/libs/uriparser/include | ||
| HEADER_PUGIXML = $(OF_PATH)/libs/pugixml/include | ||
|
|
There was a problem hiding this comment.
Curious about the quote removal - is there any downside to removing?
|
A big one!! Thanks @dimitre !!!!! |
|
|
||
| //------------------------------------------------ soundplayer | ||
| #if !defined(TARGET_NO_SOUND) | ||
| #if !defined(OF_SOUND_PLAYER_QUICKTIME) && !defined(OF_SOUND_PLAYER_FMOD) && !defined(OF_SOUND_PLAYER_OPENAL) && !defined(OF_SOUND_PLAYER_EMSCRIPTEN) && !defined(OF_SOUND_PLAYER_AV_ENGINE) && !defined(OF_SOUND_PLAYER_MEDIA_FOUNDATION) |
There was a problem hiding this comment.
Removing the checks for the sound player defines won't allow sound player definition from the compiler. Not sure how widely used this functionality is, but seems simple enough to support by keeping the checks.
Maybe just remove !defined(OF_SOUND_PLAYER_QUICKTIME)
NickHardeman
left a comment
NickHardeman
left a comment
There was a problem hiding this comment.
Thanks @dimitre!!
Added a comment or two but looks good!
3 participants
As FMOD is not the default player anymore we can remove the logic for this define and keep only USE_FMOD
Quicktime and QTkit removal
Boost references removal (not on apothecary anymore)
Some intermediate ways of making FMOD work if needed, as a transition period.
Project.xcconfig tidy up