CustomTabs not working with AndroidX

[zayass]

After migrating project to AndroidX AppAuth-Android stop showing custom tabs and always open auth forms in standalone browser.

After quick research I found that issue with "jetifier" which process libraries and replace references from old support libraries to new androidx.

This constant https://github.com/openid/AppAuth-Android/blob/master/library/java/net/openid/appauth/browser/BrowserSelector.java#L54 changed to androidx.browser.customtabs.action.CustomTabsService which leads to break hasWarmupService

Yes it looks more like a jetifier bug. But knowing google I don't think they will fix it.

Is it planned to migrate the library to androidx?

[iainmcgin]

@tikurahul is going to speak to the AndroidX team to see if they can fix this bug. We're interested in migrating to AndroidX, but I don't fully understand the implications of doing that for apps that are not ready to migrate. I'll discuss it further with the Android engineers.

[zayass]

Sounds cool, thanks.

[dbsheta]

Hi. Any updates on this? I'm working on a new app for my organization based on Android Jetpack. Cannot get this to work when androidx is enabled...

[iainmcgin]

It was suggested to me to maintain an AndroidX branch of AppAuth, so that clients can choose which variant they want based on their own migration. Jetifier / DeJetifier apparently still have some bugs, so I want to give those tools some time to mature before I fully commit to the transition.

[jcayzac]

@iainmcgin forgive the interruption if my comment is stupid, but why are you duplicating the value of android.support.customtabs.CustomTabsService.ACTION_CUSTOM_TABS_CONNECTION in your library's source code? Wouldn't simply using that one fix the problem here?

[dbsheta]

I agree with @jcayzac. As per previous comments this seems to be the only thing to be blocking the migration.

[itsvssudheesh]

I too agree with @dbsheta and @jcayzac I am also waiting for the fix.

[tikurahul]

Jetfier is now close to stable. I think Jetifier won't get us all the way, because we have a hardcoded constant which refers to the old package. We need to fix that.

[zayass]

@tikurahul Is it works now? I tried pretty same solution when open this issue and it didn't work.

[tikurahul]

It does. I wrote a sample app that uses the most recent version of jetifier and the build tools plugin.

[itsvssudheesh]

After upgrading to 7.0.1 also I am facing the same issue. When I checked the code in the library, it is still the same.
@VisibleForTesting
static final String ACTION_CUSTOM_TABS_CONNECTION =
"android.support.customtabs.action.CustomTabsService";
I think the issue still exists, but in the git master code base i can see the changes.