Fix browser package scanning#4
Merged
Merged
Conversation
PackageManager.queryIntentActivities is documented as always returning matching activities in a priority order, such that the default match would always be returned first. Therefore, we do not need to separately handle default browsers: scanning in order and recording the first "full" browser will have the same effect in all cases that matter.
Member
Author
|
+@WilliamDenniss for review. Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
Member
|
LGTM Reviewed 2 of 2 files at r1. Comments from the review on Reviewable.io |
iainmcgin
added a commit
that referenced
this pull request
Feb 29, 2016
Fix browser package scanning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PackageManager.queryIntentActivities is documented as always returning
matching activities in a priority order, such that the default match
would always be returned first. Therefore, we do not need to
separately handle default browsers: scanning in order and recording
the first "full" browser will have the same effect in all cases that
matter.
Should fix #3.