Skip to content

Handle ActivityNotFoundException.#463

Closed
gjsalot wants to merge 1 commit into
openid:masterfrom
gjsalot:gjsalot-issue-459
Closed

Handle ActivityNotFoundException.#463
gjsalot wants to merge 1 commit into
openid:masterfrom
gjsalot:gjsalot-issue-459

Conversation

@gjsalot

@gjsalot gjsalot commented Apr 4, 2019

Copy link
Copy Markdown

Resolves issue #459.

This is the same as the common behaviour in Google apps when the default browser is disabled: do nothing.

@dapp

dapp commented Apr 18, 2019

Copy link
Copy Markdown

@gjsalot can you please fix the unit tests?

@childnode

Copy link
Copy Markdown

no, that's someway symptom patching to me ... I don't see that this code should be merged because of the error is now silently catched up and not handled properly
anyway, right point for catching it up is not at the usage point but at the assignment

anyway of this error-handling issue, the cause of this is different and might be part / discussed / mentioned by #469 << #452

@Fideas

Fideas commented Jul 8, 2019

Copy link
Copy Markdown

We are currently struggling with the same issue at my company and we are looking to fix this somehow. I agree with @childnode that silently failing would result in a really bad experience for both developers and end users. I was thinking if we could just add and else clause that went something like:

else {
    val intent = Intent()
    intent.putExtra(ERROR_CAUSE, /* Some error value */)
    setResult(RESULT_CANCELED, intent)
    finish() //not sure if this is needed
}

That way we developers can decide what to do with the situation and we can display some error message to the end user so she knows that something went wrong with his browser

@agologan

agologan commented Jul 1, 2021

Copy link
Copy Markdown
Collaborator

While I agree with @childnode and the issue can be avoided by the integrator by being aware of the authorization lifecycle I did took @Fideas suggestion on this and added e047a5e
One shouldn't run into this issue if they create the AuthorizationService and authorization Intent when invoking the login process, but I do realize that might not be obvious so having some feedback in this case should help alleviate the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants