Skip to content

move onto AndroidX#553

Closed
hnljp wants to merge 6 commits into
openid:masterfrom
hnljp:androidx
Closed

move onto AndroidX#553
hnljp wants to merge 6 commits into
openid:masterfrom
hnljp:androidx

Conversation

@hnljp

@hnljp hnljp commented Jun 13, 2020

Copy link
Copy Markdown
Contributor

Migrated from the deprecated Android Support libraries to the newest versions of the AndroidX libraries.
The Android gradle plugin is updated to the current 4.0.0.
Glide is updated to the current 4.11.0, and 4.1x.x is needed for AndroidX support.

hnljp added 3 commits June 13, 2020 23:11
Migrated from the deprecated Android Support libraries to the newest versions of the AndroidX libraries.
The Android gradle plugin is updated to the current 4.0.0.
Glide is updated to the current 4.11.0, and 4.1x.x is needed for AndroidX support.
@hnljp

hnljp commented Jun 13, 2020

Copy link
Copy Markdown
Contributor Author

@iainmcgin In case you are not able to get the OpenID CLA for #508 have I created my own pullrequest.
All dependencies (except the test ones) have been updated and I am supporting Android API 30.
Have also added a comment on getting AppAuth to work on Android 11.

@hnljp

hnljp commented Jun 14, 2020

Copy link
Copy Markdown
Contributor Author

Comment thread README.md Outdated
Comment thread app/AndroidManifest.xml
@blundell

Copy link
Copy Markdown
Collaborator

@hnljp it's a bit cold to just take someones changes contributed in an effort to help an oss project and reauthor them as your own. I've signed all the CLA's its just a waiting game.

@hnljp

hnljp commented Jun 17, 2020

Copy link
Copy Markdown
Contributor Author

@hnljp it's a bit cold to just take someones changes contributed in an effort to help an oss project and reauthor them as your own. I've signed all the CLA's its just a waiting game.

I did not copy your code, I made a new pull request from the ground.
I am happy that you have signed to CLA's, so I will close the this pull request.

@hnljp hnljp closed this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants