Skip to content

Added missing custom tabs query to manifest#629

Closed
Nimrodda wants to merge 1 commit into
openid:masterfrom
Nimrodda:manifest-query-custom-tabs
Closed

Added missing custom tabs query to manifest#629
Nimrodda wants to merge 1 commit into
openid:masterfrom
Nimrodda:manifest-query-custom-tabs

Conversation

@Nimrodda

Copy link
Copy Markdown

This PR supplements PR #613 which accidentally left one query out as originally suggested in #599 (comment)

The following Intent Action is used to resolve custom tabs service in

return (pm.resolveService(serviceIntent, 0) != null);
and will fail on Android 11.

<intent>
  <action android:name="android.support.customtabs.action.CustomTabsService" />
</intent>

@amrfarid140

Copy link
Copy Markdown

Looks good @Nimrodda , Can you check the contributing guide and make sure you sign the necessary agreements?

The PR can be merged after you sign those agreements.

@Nimrodda

Nimrodda commented Dec 22, 2020

Copy link
Copy Markdown
Author

Thanks for the quick response. Signing the CLA might take a while (most likely after the holidays) since I'm representing a company. An authorized person from our company will review the CLA as soon as possible.

@agologan

agologan commented Jan 5, 2021

Copy link
Copy Markdown
Collaborator

Per PR #613 the custom tabs query was not accidentally left out.
The note in the documentation Open URLs in Custom Tabs
and our testing suggests the query is not necessary.
Please provide an example in which this fails.

@Nimrodda

Nimrodda commented Jan 5, 2021

Copy link
Copy Markdown
Author

Per PR #613 the custom tabs query was not accidentally left out.
The note in the documentation Open URLs in Custom Tabs and our testing suggests the query is not necessary.
Please provide an example in which this fails.

Thanks for you input @agologan. I bumped into a Chrome browser crash when this query was left out. I posted about it here: #292 (comment) It might be though that this crash was due to something else and it is just a coincidence that adding this query helped. Have you seen this error before?

@agologan

Copy link
Copy Markdown
Collaborator

Have run through the example you linked in #292 (on Android 11) and also tried it it with BrowserAllowList(VersionedBrowserMatcher.CHROME_CUSTOM_TAB) to avoid false positives and haven't been able to reproduce your scenario.

Not saying it's not possible but we need more information.

@Nimrodda

Copy link
Copy Markdown
Author

Have run through the example you linked in #292 (on Android 11) and also tried it it with BrowserAllowList(VersionedBrowserMatcher.CHROME_CUSTOM_TAB) to avoid false positives and haven't been able to reproduce your scenario.

Not saying it's not possible but we need more information.

I don't have any repro project for it at this point so I'll close the PR for now. Thanks!

@Nimrodda Nimrodda closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants