Added missing custom tabs query to manifest#629
Conversation
|
Looks good @Nimrodda , Can you check the contributing guide and make sure you sign the necessary agreements? The PR can be merged after you sign those agreements. |
|
Thanks for the quick response. Signing the CLA might take a while (most likely after the holidays) since I'm representing a company. An authorized person from our company will review the CLA as soon as possible. |
|
Per PR #613 the custom tabs query was not accidentally left out. |
Thanks for you input @agologan. I bumped into a Chrome browser crash when this query was left out. I posted about it here: #292 (comment) It might be though that this crash was due to something else and it is just a coincidence that adding this query helped. Have you seen this error before? |
|
Have run through the example you linked in #292 (on Android 11) and also tried it it with Not saying it's not possible but we need more information. |
I don't have any repro project for it at this point so I'll close the PR for now. Thanks! |
This PR supplements PR #613 which accidentally left one query out as originally suggested in #599 (comment)
The following Intent Action is used to resolve custom tabs service in
AppAuth-Android/library/java/net/openid/appauth/browser/BrowserSelector.java
Line 179 in 41a6aa1