Skip to content

Fixed an end session callback#285

Merged
WilliamDenniss merged 1 commit into
openid:dev-logoutfrom
iqmessenger-bv:correctPostLogoutRedirectURL
Oct 18, 2018
Merged

Fixed an end session callback#285
WilliamDenniss merged 1 commit into
openid:dev-logoutfrom
iqmessenger-bv:correctPostLogoutRedirectURL

Conversation

@AndrewMcDrew

Copy link
Copy Markdown

Addressed an issue pointed out in WIP by @Amnell

@codecov-io

codecov-io commented Sep 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #285 into dev-logout will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           dev-logout     #285   +/-   ##
===========================================
  Coverage       72.01%   72.01%           
===========================================
  Files              63       63           
  Lines            5200     5200           
===========================================
  Hits             3745     3745           
  Misses           1455     1455
Impacted Files Coverage Δ
Source/OIDAuthorizationService.m 53.75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aad291...4da8bf4. Read the comment docs.

@WilliamDenniss

Copy link
Copy Markdown
Member

Thanks for the contribution. Can you sign the CLA, or point me at your CLA if you did this already?

@AndrewMcDrew

Copy link
Copy Markdown
Author

@WilliamDenniss

Copy link
Copy Markdown
Member

That link doesn't load for me, was it posted on https://openid.net/intellectual-property/contribution-license-agreement/ yet?

@AndrewMcDrew

Copy link
Copy Markdown
Author

Yea, now I see. Haven’t sent the document to the help@oidf.org. Now also done, sorry for that.

@AndrewMcDrew

Copy link
Copy Markdown
Author

@WilliamDenniss

Copy link
Copy Markdown
Member

@mattio tested this: #259 (comment)

Looks good conceptually, LGTM.

@WilliamDenniss WilliamDenniss merged commit 229f6d6 into openid:dev-logout Oct 18, 2018
@AndrewMcDrew AndrewMcDrew mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants