Skip to content

Add missing end session endpoint information to OIDServiceConfiguration#312

Merged
WilliamDenniss merged 1 commit into
openid:dev-logoutfrom
mattio:dev-logout
Oct 18, 2018
Merged

Add missing end session endpoint information to OIDServiceConfiguration#312
WilliamDenniss merged 1 commit into
openid:dev-logoutfrom
mattio:dev-logout

Conversation

@mattio

@mattio mattio commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Added the end session endpoint to -description and -encodeWithCoder:.

Synthesized the endSessionEndpoint property for consistency.

…ynthesize the endSessionEndpoint property for consistency
@codecov-io

codecov-io commented Oct 11, 2018

Copy link
Copy Markdown

Codecov Report

Merging #312 into dev-logout will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev-logout     #312      +/-   ##
==============================================
+ Coverage       72.01%   72.02%   +0.01%     
==============================================
  Files              63       63              
  Lines            5200     5202       +2     
==============================================
+ Hits             3745     3747       +2     
  Misses           1455     1455
Impacted Files Coverage Δ
Source/OIDServiceConfiguration.m 72.89% <100%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aad291...3809c8a. Read the comment docs.

@WilliamDenniss

Copy link
Copy Markdown
Member

Thanks for this. Can you sign the CLA so I can get it merged? If you've already signed, please point me to the PDF.

@mattio

mattio commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

@WilliamDenniss WilliamDenniss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@WilliamDenniss WilliamDenniss merged commit 80d9956 into openid:dev-logout Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants