Skip to content

Error when the JSON object isn't a NSDictionary#399

Merged
WilliamDenniss merged 1 commit into
openid:masterfrom
WilliamDenniss:discovery
Jun 1, 2019
Merged

Error when the JSON object isn't a NSDictionary#399
WilliamDenniss merged 1 commit into
openid:masterfrom
WilliamDenniss:discovery

Conversation

@WilliamDenniss

Copy link
Copy Markdown
Member

Should catch the issue in #315 a little sooner.

@codecov-io

codecov-io commented Jun 1, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@820793e). Click here to learn what that means.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #399   +/-   ##
=========================================
  Coverage          ?   73.93%           
=========================================
  Files             ?       58           
  Lines             ?     5102           
  Branches          ?        0           
=========================================
  Hits              ?     3772           
  Misses            ?     1330           
  Partials          ?        0
Impacted Files Coverage Δ
Source/OIDServiceDiscovery.m 93.63% <100%> (ø)
UnitTests/OIDServiceDiscoveryTests.m 84.94% <100%> (ø)
Source/OIDAuthorizationService.m 62.55% <58.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820793e...8f9ee5d. Read the comment docs.

@StevenEWright StevenEWright left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@WilliamDenniss WilliamDenniss merged commit 28fc6c6 into openid:master Jun 1, 2019
@WilliamDenniss WilliamDenniss deleted the discovery branch June 1, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants