Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 31, 2025

Hi all,

The test test/jdk/java/net/httpclient/TimeoutResponseBodyTest.java#retriesEnabledForResponseFailure was observed timed out when run with jvm option -Xcomp. The failure details shows in JDK-8374432. Maybe it need more time for C2 to compile the httpclient classes than the default mixed mode.

So this PR read the timeout factor from jtreg, and apply the timeout factor to REQUEST_TIMEOUT by multiply it. Change has been verified locally by run the related tests test/jdk/java/net/httpclient/TimeoutResponseHeaderTest.java and test/jdk/java/net/httpclient/TimeoutResponseBodyTest.java both with -Xmixed and -Xcomp. Test-fix only, no risk,


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374432: TimeoutResponseBodyTest.java#retriesEnabledForResponseFailure fails run with -Xcomp (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29012/head:pull/29012
$ git checkout pull/29012

Update a local copy of the PR:
$ git checkout pull/29012
$ git pull https://git.openjdk.org/jdk.git pull/29012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29012

View PR using the GUI difftool:
$ git pr show -t 29012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29012.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the net net-dev@openjdk.org label Dec 31, 2025
@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 31, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2025

Webrevs

@dholmes-ora
Copy link
Member

I've updated the JBS report as we have seen further timeouts in related tests with no use of -Xcomp.

Copy link
Contributor

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @sendaoYan!

I've verified that TimeoutResponseBodyTest passes on 9c7e744 with 50 repetitions with and without -Xcomp provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

net net-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants