-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8374432: TimeoutResponseBodyTest.java#retriesEnabledForResponseFailure fails run with -Xcomp #29012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…e fails run with -Xcomp
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
I've updated the JBS report as we have seen further timeouts in related tests with no use of -Xcomp. |
vy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @sendaoYan!
I've verified that TimeoutResponseBodyTest passes on 9c7e744 with 50 repetitions with and without -Xcomp provided.
Hi all,
The test test/jdk/java/net/httpclient/TimeoutResponseBodyTest.java#retriesEnabledForResponseFailure was observed timed out when run with jvm option -Xcomp. The failure details shows in JDK-8374432. Maybe it need more time for C2 to compile the httpclient classes than the default mixed mode.
So this PR read the timeout factor from jtreg, and apply the timeout factor to
REQUEST_TIMEOUTby multiply it. Change has been verified locally by run the related tests test/jdk/java/net/httpclient/TimeoutResponseHeaderTest.java and test/jdk/java/net/httpclient/TimeoutResponseBodyTest.java both with -Xmixed and -Xcomp. Test-fix only, no risk,Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29012/head:pull/29012$ git checkout pull/29012Update a local copy of the PR:
$ git checkout pull/29012$ git pull https://git.openjdk.org/jdk.git pull/29012/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29012View PR using the GUI difftool:
$ git pr show -t 29012Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29012.diff
Using Webrev
Link to Webrev Comment