8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix)

[fmeum]

FileSystemProvider.readAttributesIfExists now returns null for a path with a true prefix that is not a directory rather than throwing NotDirectoryException.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix) (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29013/head:pull/29013
$ git checkout pull/29013

Update a local copy of the PR:
$ git checkout pull/29013
$ git pull https://git.openjdk.org/jdk.git pull/29013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29013

View PR using the GUI difftool:
$ git pr show -t 29013

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29013.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fmeum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fmeum This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374441: (fs) FileSystemProvider.readAttributesIfExists throws "Not a directory" when element in path is not directory should return null for ENOTDIR (unix)

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• de81d38: 8374456: JVM crashes with "assert(resolved_method->method_holder()->is_linked()) failed: must be linked" when run with large value for PreallocatedOutOfMemoryErrorCount
• fa8ea6b: 8374168: Resolve disabled warnings in JDWP agent
• 5fd095f: 8372591: assert(!current->cont_fastpath() || freeze.check_valid_fast_path()) failed
• ... and 17 more: https://git.openjdk.org/jdk/compare/481ef1de7a2721adfb8a48bb56513e617347c122...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fmeum The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (868e0f41)
• 01: Full - Incremental (91f4b3ac)
• 00: Full (d7377abf)

[fmeum]

The linux-x64 debug build job consistently fails with "No space left on device", which doesn't appear to be related to this PR.

[AlanBateman]

FileSystemProvider.readAttributesIfExists is part of the SPI so should be rare to see a direct usage. Instead, the usages are indirect, e.g. Files.isXXX to avoid using exceptions for control flow. Would it be possible to update the JBS issue or this PR with a some context as to how you ran into this. The implementation of APIs such as Files.isXXX will already handle the FileSystemException so the change should be transparent. I'm wondering if we've missed something in another usage (of some API) that causes the FileSystemException to surface.

[fmeum]

I added more details to the JBS issue. Bazel would like to use the provider method directly so that it doesn't have to pay for the cost of an exception in the case where a file does not exist, but our tests show that the method still throws in some edge cases in which the file is considered missing by higher-level APIs.

[AlanBateman]

Title mismatch between PR and JBS.

Can you update the PR title to match the JBS issue?

[fmeum]

/integrate

[openjdk]

@fmeum
Your change (at version 868e0f4) is now ready to be sponsored by a Committer.

[AlanBateman]

/sponsor

[openjdk]

Going to push as commit 2fbc416.
Since your change was applied there have been 21 commits pushed to the master branch:

• d063c95: 8374507: GHA: Limit debug symbols generation to conserve disk space
• de81d38: 8374456: JVM crashes with "assert(resolved_method->method_holder()->is_linked()) failed: must be linked" when run with large value for PreallocatedOutOfMemoryErrorCount
• fa8ea6b: 8374168: Resolve disabled warnings in JDWP agent
• ... and 18 more: https://git.openjdk.org/jdk/compare/481ef1de7a2721adfb8a48bb56513e617347c122...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman @fmeum Pushed as commit 2fbc416.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.