8374293: Jshell throws an error and crashes when using keyword Public #29018
+16
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jdk.jshell.SourceCodeAnalysis#highlightsshould not return overlapping highlights, so useTreeSetfor deduplication and sorting.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29018/head:pull/29018$ git checkout pull/29018Update a local copy of the PR:
$ git checkout pull/29018$ git pull https://git.openjdk.org/jdk.git pull/29018/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29018View PR using the GUI difftool:
$ git pr show -t 29018Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29018.diff
Using Webrev
Link to Webrev Comment