8374469: Mixed jstack does not work on Windows #29019
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we run
jhsdb jstack --mixedon Windows, we can see top of call frames only as following:This is long standing bugs since JDK 9 at least (maybe this includes older JDK releases).
We cannot depend on base pointer to unwind call frames, but SA do that.
This PR use GetStackTrace to find caller frame, then native call frames would be unwinded.
However it has still problems for JIT'ed frames because it does not have a hint for unwinder like RtlAddFunctionTable. But it would affect entire of JIT compilers, so I've limited the change to SA.
This change passed serviceability/sa tests on Windows 11.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29019/head:pull/29019$ git checkout pull/29019Update a local copy of the PR:
$ git checkout pull/29019$ git pull https://git.openjdk.org/jdk.git pull/29019/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29019View PR using the GUI difftool:
$ git pr show -t 29019Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29019.diff
Using Webrev
Link to Webrev Comment