Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Jan 3, 2026

Remove group :serviceability_ttf_virtual and mark only failing tests with requires.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374483: Eliminate :serviceability_ttf_virtual group and mark svc non-virtual tests with requires (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29024/head:pull/29024
$ git checkout pull/29024

Update a local copy of the PR:
$ git checkout pull/29024
$ git pull https://git.openjdk.org/jdk.git pull/29024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29024

View PR using the GUI difftool:
$ git pr show -t 29024

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29024.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2026

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@lmesnik
Copy link
Member Author

lmesnik commented Jan 3, 2026

/cc serviceability

@openjdk
Copy link

openjdk bot commented Jan 3, 2026

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374483: Eliminate :serviceability_ttf_virtual group and mark svc non-virtual tests with requires

Reviewed-by: syan, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jan 3, 2026
@openjdk
Copy link

openjdk bot commented Jan 3, 2026

@lmesnik
The serviceability label was successfully added.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 3, 2026
@openjdk
Copy link

openjdk bot commented Jan 3, 2026

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2026

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. None of the modified tests should be run on a virtual thread, even if the test itself will be testing some virtual thread functionality.

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2026
@lmesnik
Copy link
Member Author

lmesnik commented Jan 6, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

Going to push as commit c611da2.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2026
@openjdk openjdk bot closed this Jan 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@lmesnik Pushed as commit c611da2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants