Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Jan 5, 2026

This patch adds missing @Override annotations to methods in the com.sun.java.swing.plaf.motif package that override methods from a superclass or interface.
Only source annotations are added; there are no behavioral changes.

The previous patch for com.sun.beans can be found here: #27887.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374493: Add missing @Override annotations in "com.sun.java.swing.plaf.motif" package (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29026/head:pull/29026
$ git checkout pull/29026

Update a local copy of the PR:
$ git checkout pull/29026
$ git pull https://git.openjdk.org/jdk.git pull/29026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29026

View PR using the GUI difftool:
$ git pr show -t 29026

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29026.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8374493 Add missing @Override annotations in "com.sun.java.swing.plaf.motif" package 8374493: Add missing @Override annotations in "com.sun.java.swing.plaf.motif" package Jan 5, 2026
@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review January 6, 2026 18:27
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant