-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373476 : (tz) Update Timezone Data to 2025c #29029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into |
|
@johnyjose30 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@johnyjose30 Reviewer |
|
@johnyjose30 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
coffeys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
naotoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For the JIRA issue, please fix the last paragraph in the problem text:
Commentary now also uses characters from the set -''""•≤ as this
can be useful and should work with current applications. This
also affects data in iso3166.tab and zone1970.tab, which now
contain strings like "Côte d'Ivoire" instead of "Côte d'Ivoire".
which seems to have converted the non-ASCII quotes to ASCII equivalents, which made the paragraph not making sense. FWIW, the original was:
Commentary now also uses characters from the set –‘’“”•≤ as this
can be useful and should work with current applications. This
also affects data in iso3166.tab and zone1970.tab, which now
contain strings like “Côte d’Ivoire” instead of “Côte d'Ivoire”
|
/integrate |
|
@johnyjose30 |
|
/sponsor |
|
Going to push as commit 5df183b.
Your commit was automatically rebased without conflicts. |
|
@coffeys @johnyjose30 Pushed as commit 5df183b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
tzdata changes for 2025c
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29029/head:pull/29029$ git checkout pull/29029Update a local copy of the PR:
$ git checkout pull/29029$ git pull https://git.openjdk.org/jdk.git pull/29029/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29029View PR using the GUI difftool:
$ git pr show -t 29029Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29029.diff
Using Webrev
Link to Webrev Comment