Skip to content

Conversation

@johnyjose30
Copy link
Contributor

@johnyjose30 johnyjose30 commented Jan 5, 2026

tzdata changes for 2025c


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373476: (tz) Update Timezone Data to 2025c (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29029/head:pull/29029
$ git checkout pull/29029

Update a local copy of the PR:
$ git checkout pull/29029
$ git pull https://git.openjdk.org/jdk.git pull/29029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29029

View PR using the GUI difftool:
$ git pr show -t 29029

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29029.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back johnyjose30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373476: (tz) Update Timezone Data to 2025c

Reviewed-by: coffeys, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@johnyjose30
Copy link
Contributor Author

/reviewer credit @naotoj @coffeys

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@johnyjose30
Reviewer naoto successfully credited.

Reviewer coffeys successfully credited.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@johnyjose30 The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2026
Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For the JIRA issue, please fix the last paragraph in the problem text:

Commentary now also uses characters from the set -''""•≤ as this
     can be useful and should work with current applications. This
     also affects data in iso3166.tab and zone1970.tab, which now
     contain strings like "Côte d'Ivoire" instead of "Côte d'Ivoire".

which seems to have converted the non-ASCII quotes to ASCII equivalents, which made the paragraph not making sense. FWIW, the original was:

Commentary now also uses characters from the set –‘’“”•≤ as this
     can be useful and should work with current applications.  This
     also affects data in iso3166.tab and zone1970.tab, which now
     contain strings like “Côte d’Ivoire” instead of “Côte d'Ivoire”

@johnyjose30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@johnyjose30
Your change (at version 512f7a5) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Jan 6, 2026

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

Going to push as commit 5df183b.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 6, 2026
@openjdk openjdk bot closed this Jan 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 6, 2026
@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@coffeys @johnyjose30 Pushed as commit 5df183b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants