8374507: GHA: Limit debug symbols generation to conserve disk space

[shipilev]

I have noticed that Linux x86_64 fastdebug build jobs started to fail in GHA with no free space left on device. Instrumenting GHA runs shows we have about 17G of free space on those runners.

Filesystem  Size  Used  Avail Use% Mounted on
/dev/root    72G   56G   17G   78% /

GHA docs say there is 14G of guaranteed disk space on runners. This is a bit beyond what our fastdebug builds need. My local build says disabling debug symbols bundling reduces the space requirement from 16G -> 11G, without regressing tests.

Testing:

• Ad-hoc JVM crash to verify that stack trace generation still works
• GHA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374507: GHA: Limit debug symbols generation to conserve disk space (Enhancement - P4)

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29030/head:pull/29030
$ git checkout pull/29030

Update a local copy of the PR:
$ git checkout pull/29030
$ git pull https://git.openjdk.org/jdk.git pull/29030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29030

View PR using the GUI difftool:
$ git pr show -t 29030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29030.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374507: GHA: Limit debug symbols generation to conserve disk space

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 27dbdec: 8374217: Remove IO.java test from AOT ProblemList
• 4458cab: 8367627: C2: Missed Ideal() optimization opportunity with MemBar
• 6ae3e06: 8373508: C2: sinking CreateEx out of loop breaks the graph
• ... and 3 more: https://git.openjdk.org/jdk/compare/6eaabed55ca4670d8c317f0a4323ccea4dd0b9ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5efefeee)

[shipilev]

Thank you! I am integrating now to unbreak GHA.

/integrate

[openjdk]

Going to push as commit d063c95.
Since your change was applied there have been 9 commits pushed to the master branch:

• de81d38: 8374456: JVM crashes with "assert(resolved_method->method_holder()->is_linked()) failed: must be linked" when run with large value for PreallocatedOutOfMemoryErrorCount
• fa8ea6b: 8374168: Resolve disabled warnings in JDWP agent
• 5fd095f: 8372591: assert(!current->cont_fastpath() || freeze.check_valid_fast_path()) failed
• ... and 6 more: https://git.openjdk.org/jdk/compare/6eaabed55ca4670d8c317f0a4323ccea4dd0b9ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit d063c95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[RealCLanger]

@shipilev I'm a bit late to the game here but maybe we should try --with-external-symbols-in-bundles=public on Windows in order to get file and method names in case of crashes. Not sure whether it'll be again too much of disk space needed, though...

[shipilev]

@shipilev I'm a bit late to the game here but maybe we should try --with-external-symbols-in-bundles=public on Windows in order to get file and method names in case of crashes. Not sure whether it'll be again too much of disk space needed, though...

Oh. Yes, please try that? Really we wanted to improve Linux side of things, that is where we are scratching the runner space limits. I have not looked at Windows side at all; so please experiment and see how bad is it? I also have this improvement for Linux/MacOS: #29056 -- again, does not help Windows, since I cannot find a useful/relevant MSVC toggle there.

[erikj79]

I'm a bit late to the game here but maybe we should try --with-external-symbols-in-bundles=public on Windows in order to get file and method names in case of crashes. Not sure whether it'll be again too much of disk space needed, though...

RunTests.gmk sets up _NT_SYMBOL_PATH based on $(SYMBOLS_IMAGE_DIR) if that is provided when invoking make run-test-prebuilt. At least in our internal testing setup, we get symbols for Windows crashes. Is that not the case in GHA?