Skip to content

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jan 5, 2026

JShell tests where converted to use JUnit instead of TestNG by this commit:
b0ca9bf

As part of the conversion, the @Test annotation had to be copied from classes to test methods, as JUnit requires every test method to be annotated. Sadly the tool doing the conversion moved the annotation to some non-test methods as well. This PR fixes that. The tool has been fixed as well.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374434: Several JShell tests report JUnit discovery warnings (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29034/head:pull/29034
$ git checkout pull/29034

Update a local copy of the PR:
$ git checkout pull/29034
$ git pull https://git.openjdk.org/jdk.git pull/29034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29034

View PR using the GUI difftool:
$ git pr show -t 29034

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29034.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2026

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jan 5, 2026
@openjdk
Copy link

openjdk bot commented Jan 5, 2026

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant