8374434: Several JShell tests report JUnit discovery warnings #29034
+0
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JShell tests where converted to use JUnit instead of TestNG by this commit:
b0ca9bf
As part of the conversion, the
@Testannotation had to be copied from classes to test methods, as JUnit requires every test method to be annotated. Sadly the tool doing the conversion moved the annotation to some non-test methods as well. This PR fixes that. The tool has been fixed as well.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29034/head:pull/29034$ git checkout pull/29034Update a local copy of the PR:
$ git checkout pull/29034$ git pull https://git.openjdk.org/jdk.git pull/29034/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 29034View PR using the GUI difftool:
$ git pr show -t 29034Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29034.diff
Using Webrev
Link to Webrev Comment