Map Compton subshell data to atomic relaxation data#3392
Merged
Conversation
paulromano
approved these changes
May 5, 2025
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the improvement @amandalund!
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A known issue in our Compton scattering model is that the subshell data from Biggs et al. doesn't match the ENDF/B atomic relaxation data (which often has more subshells). As a result, we are sometimes ejecting an electron in Compton scattering and filling a different vacancy in atomic relaxation. I think one reasonable solution is to create a mapping of the Compton to relaxation subshells based on the binding energy. While the number of electrons still won't always match, this isn't used in atomic relaxation, so I think it's ok.
For completeness, this is a summary of all the subshells that are mismatched and remapped
Fixes #1942
Checklist