Refactor Ray class into its own file#3845
Merged
Merged
Conversation
Contributor
Contributor
Author
|
Yes, I intend to create a subclass of Ray with the functionality in that issue for point detector purpose. |
paulromano
approved these changes
Mar 6, 2026
paulromano
enabled auto-merge (squash)
March 6, 2026 00:16
jon-proximafusion
pushed a commit
to shimwell/openmc
that referenced
this pull request
Apr 13, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the cpp Ray class is located at plot.cpp.
I intend to use this class for the point detector feature.
This PR move this class into ray.cpp because this class is useful for general ray tracing and not solely for plotting.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)