Fix a bug in compton scattering electron shell selection#3874
Open
GuySten wants to merge 28 commits into
Open
Conversation
5 tasks
GuySten
marked this pull request as ready for review
March 12, 2026 21:14
GuySten
marked this pull request as draft
April 1, 2026 14:56
GuySten
marked this pull request as ready for review
April 1, 2026 19:06
Contributor
Author
|
@paulromano, can you check my fix? I think the current compton scattering is inaccurate and cause negative heating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, in compton scatter openmc select electron shell to interact with irrespectively of the incident photon energy. This PR change that to resample the shell until the incident photon energy is higher than the electron binding energy.
This PR also change the compton doppler broadening algorithm to better match https://serpent.vtt.fi/download/Kaltiaisenaho_MSc_2016.pdf.
Checklist