Turn on weight windows if weight_windows_file is specified#4007
Merged
Conversation
GuySten
enabled auto-merge (squash)
July 9, 2026 23:13
shimwell
added
the
Merging Soon
jtramm
pushed a commit
to jtramm/openmc
that referenced
this pull request
Jul 17, 2026
jtramm
pushed a commit
to jtramm/openmc
that referenced
this pull request
Jul 17, 2026
With the auto-enable behavior cherry-picked from develop (openmc-dev#4007), convert_to_multigroup and the bootstrap test no longer need to set weight_windows_on explicitly alongside the file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user specifies
settings.weight_windows, OpenMC automatically will turn weight windows on. However, when they specifysettings.weight_windows_file, it doesn't automatically turn weight windows on. This PR changes the behavior so that weight windows are automatically enabled ifsettings.weight_windows_fileis specified.Checklist
I have followed the style guidelines for Python source files (if applicable)