Skip to content

Change defaults for get_task to be lazy#1354

Merged
PGijsbers merged 5 commits into
developfrom
add/1034
Oct 1, 2024
Merged

Change defaults for get_task to be lazy#1354
PGijsbers merged 5 commits into
developfrom
add/1034

Conversation

@PGijsbers

@PGijsbers PGijsbers commented Sep 28, 2024

Copy link
Copy Markdown
Collaborator

Unfortunately, we missed a warning last patch, so it still won't close #1034

edit: letting CI run since local unit tests are slow for some reason.

@codecov-commenter

codecov-commenter commented Sep 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.02%. Comparing base (d37542b) to head (2ff431c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
openml/tasks/functions.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1354      +/-   ##
===========================================
- Coverage    84.12%   84.02%   -0.10%     
===========================================
  Files           38       38              
  Lines         5298     5297       -1     
===========================================
- Hits          4457     4451       -6     
- Misses         841      846       +5     
Flag Coverage Δ
84.02% <20.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread openml/tasks/functions.py
@PGijsbers PGijsbers merged commit a55a3fc into develop Oct 1, 2024
@PGijsbers PGijsbers deleted the add/1034 branch October 1, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't download (large) datasets by default

3 participants