Remove R2 from the templates used when creating wrangler.jsonc and open-next.config.ts files#1132
Remove R2 from the templates used when creating wrangler.jsonc and open-next.config.ts files#1132dario-piotrowicz wants to merge 1 commit intomainfrom
wrangler.jsonc and open-next.config.ts files#1132Conversation
…`open-next.config.ts` files
🦋 Changeset detectedLatest commit: ee01b88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
| The `migrate` command no longer sets up the R2 caching in the `wrangler.jsonc` and `open-next.config.ts` files it creates, this allows newly migrated applications to be deployed right away without forcing the user to enable R2 nor set an R2 bucket. | ||
|
|
||
| Ideally applications should use caching for optimal results, so a warning is now also presented at the end of the migration recommending users to set up caching. |
There was a problem hiding this comment.
should we default to the staticAssetsIncrementalCache in this case?
There was a problem hiding this comment.
we discussed this and we think that it's better not to set any caching at all, this will make it easier to users (or us if we want to provide an automated way to then configure caching) to apply a caching implementation.
If we were to set a different caching solution, like the static or kv ones, then if people later wanted to move onto R2 there'd be more steps to do that, so it seems better to just not set anything at all here (instead of setting something sub-par).
what do you think? 🙂
There was a problem hiding this comment.
i mean, i think we should be serving the stuff generated at build-time from static assets for the incremental cache, shouldn't we? i guess it falls back to the dummy one otherwise. up to you /shrug
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Let's discuss more before doing this.
|
Closing in favour of #1133 |
dario-piotrowicz
deleted the
dario/DEVX-2491/remove-caching-from-migrate
branch
3 participants
Fixes https://jira.cfdata.org/browse/DEVX-2491
This PR removes R2 from the templates used when creating
wrangler.jsoncandopen-next.config.tsfiles since this generally results on an application that can't actually be deployed.For more details please see the included changesets.