Write metric_ids and metric_values as lists - #130
Merged
Conversation
* average_batch_r2 and flowsom_mapping_similarity wrote them as scalars
Member
Author
|
The previous notation was ok, but let's go for it anyways |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
file_score.yamldeclares bothmetric_idsandmetric_valuesasmultiple: true, andcommon/schemas/results_v4/results.jsontypes the correspondingmetric_names/metric_valuesas arrays. Two metrics write them as scalars instead:metrics/average_batch_r2--"metric_ids": "average_batch_r2_ct","metric_values": average_batch_r2_ctmetrics/flowsom_mapping_similarity--metric_ids = "flowsom_mean_mapping_similarity",metric_values = fs_mapping_similarity_avg(a length-1 R vector, which reticulate hands to anndata as a plain Python string/float)The other four metric components already write lists. This PR makes these two do the same, so the score files are consistent and the results schema holds for every component.
Found while reviewing the task ahead of the next full benchmark run -- see also the sibling PRs.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!