Clean up stale mock parameters and dead code - #133
Merged
Conversation
* Point info.image at thumbnail.svg instead of the template placeholder * Fix the VIASH START blocks of process_dataset, gaussnorm and shuffle_integration_within_batch so the scripts can be run locally again * Drop the unused subset_by_celltype() helper * Drop the unused imports and a debugging print in average_batch_r2
Member
Author
|
This PR is trivial enough to merge directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Housekeeping picked up while reading through the repo. No behaviour changes.
_viash.yaml:info.imagewas still the literal template placeholder ("The name of the image file to use for the component on the website."). Points atthumbnail.svgnow.Three
## VIASH STARTblocks had drifted so far that the scripts can't be run locally any more:data_processors/process_datasetstill declaresoutput_validationand never declaresoutput_unintegrated.methods/gaussnormhastemp_dir: '/tmp'-- YAML syntax inside an Rlist(), so the block doesn't even parse -- plus aresources_test/.../cyto_spleen_subset/path that no longer exists and noresources_dir.control_methods/shuffle_integration_within_batchstill declares a singleoutputand noresources_dir, while the script writesoutput_integrated_split1/2and doessys.path.append(meta["resources_dir"]).Viash replaces these blocks at build time, so none of this affects the built components -- it just makes the scripts annoying to debug by hand.
Dropped
subset_by_celltype()fromsrc/utils/helper_functions.R. Nothing calls it, and it only returns its result by accident (via the value of the assignment in theif/else).Dropped the unused
concat_paired_samples/fit_r2imports and a### Debugging line, can be removed laterprint of the full obs frommetrics/average_batch_r2, and made the log line say "per cell type" rather than "global".I left the CHANGELOG entries that mention components which no longer exist (
methods/mnn,metrics/cms,metrics/emd_per_samples,control_methods/shuffle_integration) alone -- rewriting history entries felt like your call rather than mine. Happy to add explicit removal entries if you'd prefer that.Found while reviewing the task ahead of the next full benchmark run -- see also the sibling PRs. Note that all of these PRs append to the bottom of
CHANGELOG.md, so whichever ones land after the first will need a one-line rebase there.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!