Skip to content

Fix output dimension in simple_mlp_predict #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcannood merged 2 commits into from
Jul 29, 2026
Merged

Fix output dimension in simple_mlp_predict #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7895cb4
fix output dimension in simple_mlp_predict
rcannood Jul 28, 2026
2e08903
Merge branch 'main' into fix/simple-mlp-predict-output-dim
rcannood Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
## BUG FIXES

* Fix the component paths, build paths and `rename_keys` separator in the helper scripts, which prevented `scripts/create_datasets/test_resources.sh` and both `run_test.sh` scripts from running at all (PR #22).
*

* `cellmapper_scvi`: Fix postfix due to breaking changes in package (PR #23).

* `simple_mlp_predict`: Size the model output with `input_train_mod2.n_vars` instead of `input_test_mod1.n_vars`. The two only coincide on the test resources, so this crashed on every real dataset (PR #24).

# task_predict_modality 0.1.1

## NEW FUNCTIONALITY
Expand Down
4 changes: 2 additions & 2 deletions src/methods/simple_mlp/simple_mlp_predict/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def _predict(model,dl):

print('Start predict', flush=True)
if task == 'GEX2ATAC':
y_pred = ymean*np.ones([input_test_mod1.n_obs, input_test_mod1.n_vars])
y_pred = ymean*np.ones([input_test_mod1.n_obs, input_train_mod2.n_vars])
else:
folds = [0, 1, 2]

Expand All @@ -82,7 +82,7 @@ def _predict(model,dl):
model_inf = MLP.load_from_checkpoint(
ckpt,
in_dim=X.shape[1],
out_dim=input_test_mod1.n_vars,
out_dim=input_train_mod2.n_vars,
ymean=ymean,
config=config
)
Expand Down
Loading