Correct metric bounds, labels and the logcounts type - #26
Merged
Conversation
file_dataset_sp.yaml declared `logcounts` as integer. Log-transformed counts are doubles, and the shipped datasets store them as such.
* clustering_ari was declared -Inf..+Inf. The adjusted Rand index is at most 1 and does not go below -0.5, so the report had nothing to rescale against. * ctdeconvolute_rmse was 0..+Inf, but it is the RMSE between two vectors of proportions, so it cannot exceed 1. * The eight labels were the metric ids repeated back; the ks metrics already had readable ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three config declarations that did not match what the components actually produce. No behaviour changes; they affect how the report rescales and labels things.
file_dataset_sp.yamldeclaredlogcountsasinteger. Log-transformed counts are doubles, and the shipped datasets store them as such.clustering_ariwas declared-Inf..+Inf. The adjusted Rand index is at most 1 and does not go below -0.5, so the report had nothing to rescale against.ctdeconvolute_rmsewas0..+Inf, but it is the RMSE between two vectors of proportions, so it cannot exceed 1.Also gave the eight
downstreammetrics readable labels -- they were the metric ids repeated back, while the ks metrics already had proper ones.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!