Match any commons-collections 4.x in migrateDependencies test - #142
Merged
Conversation
4.6.0 broke the pinned 4.5.x assertion; the recipe targets 4.x. Anchor the regex on the property to avoid matching <modelVersion>4.0.0</modelVersion>.
timtebeek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
mainfailed on version drift, not on the Gradle wrapper bump it landed with.UpgradeApacheCommonsCollections_3_4Test.migrateDependenciespinned the expected upgrade to4.5.x, but commons-collections4 released 4.6.0. The recipe targets4.x, so the assertion now matches any4.xrelease. The regex is anchored on the<commons-collections.version>property, otherwise a bare4\.\d+\.\d+matches<modelVersion>4.0.0</modelVersion>first.