[Bug] Correlation saved object entities to not be strict#10403
Merged
angle943 merged 5 commits intoopensearch-project:mainfrom Aug 12, 2025
Merged
[Bug] Correlation saved object entities to not be strict#10403angle943 merged 5 commits intoopensearch-project:mainfrom
angle943 merged 5 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
sumukhswamy
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
Maosaic,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
d-buckner,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
wanglam,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
TackAdam
approved these changes
Aug 12, 2025
angle943
approved these changes
Aug 12, 2025
LDrago27
approved these changes
Aug 12, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10403 +/- ##
==========================================
- Coverage 61.76% 61.75% -0.01%
==========================================
Files 4242 4242
Lines 107874 107874
Branches 17572 17572
==========================================
- Hits 66623 66621 -2
- Misses 36775 36777 +2
Partials 4476 4476
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Does this make the field unindexed and therefore not searchable? |
Collaborator
Author
only the entities field yes, as the object init would be dynamic |
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Sep 22, 2025
…project#10403) * experimental entity to store any field and not be strict Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * experimental entity to store any field and not be strict Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * unnecessary file Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * Changeset file for PR opensearch-project#10403 created/updated --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the entities field mapping in the correlations saved object type from enabled: true to enabled: false to be able to add non strict entities.
Bug for #10386
Changelog
-fix: correlation object to have entities field which is dynamic and not strict
Check List
yarn test:jestyarn test:jest_integration