[Explore] Update dataset interface in fields selector component#10483
Merged
Maosaic merged 3 commits intoopensearch-project:mainfrom Sep 5, 2025
Merged
[Explore] Update dataset interface in fields selector component#10483Maosaic merged 3 commits intoopensearch-project:mainfrom
Maosaic merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Joey Liu <jiyili@amazon.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10483 +/- ##
==========================================
+ Coverage 61.93% 61.96% +0.02%
==========================================
Files 4271 4272 +1
Lines 108978 109011 +33
Branches 17921 17922 +1
==========================================
+ Hits 67494 67547 +53
+ Misses 36912 36884 -28
- Partials 4572 4580 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Joey Liu <jiyili@amazon.com>
Maosaic
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Maosaic
requested review from
angle943,
d-buckner,
ps48,
raintygao and
wanglam
as code owners
ruchidh
reviewed
Sep 4, 2025
| import { uiSettingsServiceMock } from './ui_settings/ui_settings_service.mock'; | ||
| import { workspacesServiceMock } from './workspace/workspaces_service.mock'; | ||
|
|
||
| import { keyboardShortcutServiceMock } from './keyboard_shortcut/keyboard_shortcut_service.mock'; |
Collaborator
There was a problem hiding this comment.
is this change part of same requirement ?
Collaborator
Author
There was a problem hiding this comment.
This change is require for the test mock helper getStubDataView due to the recent keyboard shortcut change to CoreSystem
LDrago27
approved these changes
Sep 4, 2025
angle943
approved these changes
Sep 5, 2025
ashwin-pc
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Sep 17, 2025
…search-project#10483) * [Explore] Update dataset interface in fields selector component Signed-off-by: Joey Liu <jiyili@amazon.com> * Changeset file for PR opensearch-project#10483 created/updated * update snapshot Signed-off-by: Joey Liu <jiyili@amazon.com> --------- Signed-off-by: Joey Liu <jiyili@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update fields selector component interface to consume
DataView/DataSetinstead ofIndexPattern.Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration