[BUG] Fix obsolete snapshots for test within data source management plugin#6185
Merged
BionIT merged 2 commits intoopensearch-project:mainfrom Mar 18, 2024
Merged
[BUG] Fix obsolete snapshots for test within data source management plugin#6185BionIT merged 2 commits intoopensearch-project:mainfrom
BionIT merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lu Yu <nluyu@amazon.com>
ashwin-pc
reviewed
Mar 18, 2024
| - [BUG][Multiple Datasource] Add a migration function for datasource to add migrationVersion field ([#6025](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6025)) | ||
| - [BUG][MD]Expose picker using function in data source management plugin setup([#6030](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6030)) | ||
| - [BUG][Multiple Datasource] Fix data source filter bug and add tests ([#6152](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6152)) | ||
| - [BUG][Multiple Datasource] Fix obsolete snapshots for test within data source management plugin ([#6185](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6185)) |
Member
There was a problem hiding this comment.
Nit: We dont need a changelog entry when the fix happens in the same release as the feature since the bug isnt visible yet
Collaborator
Author
There was a problem hiding this comment.
Got it! Thanks for pointing that out!
ashwin-pc
approved these changes
Mar 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6185 +/- ##
==========================================
+ Coverage 67.23% 67.25% +0.01%
==========================================
Files 3344 3344
Lines 64792 64792
Branches 10427 10427
==========================================
+ Hits 43566 43578 +12
+ Misses 18684 18672 -12
Partials 2542 2542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bandinib-amzn
approved these changes
Mar 18, 2024
Flyingliuhub
approved these changes
Mar 18, 2024
yujin-emma
approved these changes
Mar 18, 2024
ZilongX
approved these changes
Mar 18, 2024
xinruiba
approved these changes
Mar 18, 2024
77 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
…lugin (#6185) * remove obsolete snapshots Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit a9e874f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BionIT
pushed a commit
that referenced
this pull request
Mar 26, 2024
…lugin (#6185) (#6266) * remove obsolete snapshots Signed-off-by: Lu Yu <nluyu@amazon.com> * add change log Signed-off-by: Lu Yu <nluyu@amazon.com> --------- Signed-off-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit a9e874f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change removes obsolete snapshots to fix the test under data source management plugin
Issues Resolved
Screenshot
Testing the changes
The obsolete snapshots from the tests were removed by executing
yarn test:jest -u src/plugins/data_source_management/and the following is the outputCheck List
yarn test:jestyarn test:jest_integration