Enable UI Metric Collector#6203
Conversation
fec5871 to
1f31cdd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6203 +/- ##
==========================================
- Coverage 67.69% 67.68% -0.01%
==========================================
Files 3415 3415
Lines 66879 66858 -21
Branches 10882 10876 -6
==========================================
- Hits 45273 45256 -17
- Misses 18959 19000 +41
+ Partials 2647 2602 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Do we have feature flag to disable ? There used to be search telemetry feature which collect search query made from OSD and saved into saved object that cause significantly performance issue. |
|
Thanks @ananzh. I have fixed the failing test cases. Adding the screenshots for reference. |
@ananzh |
| # Set the value to true to enable workspace feature | ||
| # workspace.enabled: false | ||
|
|
||
| # Set the value to true to enable Ui Metric Collectors in Usage Collector |
There was a problem hiding this comment.
Let's call our this might cause permission issue to OpenSearch. turn on with caution
There was a problem hiding this comment.
Updated the comments
|
What are the telemetry data has been stored into saved object, i didn't see any functional test and integration test. could we add a few ? if not planned for automation, could we add manual test result? |
|
@seraphjiang Thanks for your suggestion. I have created this PR opensearch-project/opensearch-dashboards-functional-test#1223 to include a functional tests for the above change. |
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit 5258d83) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit 5258d83) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit 5258d83) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit aac0ecb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 5258d83) (cherry picked from commit aac0ecb) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Thanks @LDrago27 for adding tests. looks like the test PR is still open. are we also plan to get test merge in 2.14? |
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

Description
This changes is to enable UI Metric Collectors which would save the UI metrics and application usage information across the dashboard into the saved object.
Feature Flag: usageCollection.uiMetric.enabled
Default Value: false
Testing the changes
Check List
yarn test:jestyarn test:jest_integration