Refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector by zhongnansu · Pull Request #6544 · opensearch-project/OpenSearch-Dashboards

zhongnansu · 2024-04-18T21:06:52Z

Description

Add dataSourceManagement as an optional plugin of saved obeect manamgent plugin
get picker compoenent by const DataSourceSelector = dataSourceManagement.ui , instead of direct inport
Make Datasource selector non-clearable
remove the usage of hideLocalCluster, and no need pass to DataSourceSelector as props
this change will also let the default label to be rendered successfully

Issues Resolved

#6369
fix #6546

Screenshot

Testing the changes

With datasource enabled and localCluster hidden and no avaliable data sources. It should disable the import button

With datasource enabled, and localCluster shown, no other avaliable data sources.
With datasource enabled, and LocalCluster shown, with other data sources
With data source disabled

Changelog

refactor: refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-04-18T21:07:33Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-04-18T21:21:59Z

❌ Invalid Prefix

Invalid description prefix. Found "refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

github-actions · 2024-04-18T21:23:16Z

❌ Invalid Prefix

Invalid description prefix. Found "refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

github-actions · 2024-04-18T21:24:26Z

❌ Invalid Prefix

Invalid description prefix. Found "refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

github-actions · 2024-04-18T21:24:40Z

❌ Invalid Prefix

Invalid description prefix. Found "refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

zhyuanqi · 2024-04-18T22:21:28Z

...ugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx

            disabled={!this.props.dataSourceEnabled}
-            hideLocalCluster={this.props.hideLocalCluster}
            fullWidth={true}
+            isClearable={false}


Hi Zhongnan, what is this isClearable do? I did not find it in the doc here. https://quip-amazon.com/UepCAPYFGtKC/Use-Data-Source-Menu-to-Nav-Bar-or-Data-Source-Selector-inside-Page#temp:C:eCC8e412f6d533d4057af4524ca8

it was a new prop added by this PR https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6298/files, it's being passed to EuiComboBox
basically it make sure you can't clear the input, but you can switch to other option.

...ugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx

BionIT · 2024-04-19T02:14:06Z

Can we add test details? Data source turn on and off, hide local cluster on and off, etc

zhongnansu · 2024-04-19T08:48:59Z

Can we add test details? Data source turn on and off, hide local cluster on and off, etc

sure, updated PR description with more test details and screenshots

…i API get DataSourceSelector Signed-off-by: Zhongnan Su <szhongna@amazon.com>

…i API to get DataSourceSelector (#6544) * Refactor saved object management plugin to use datasourceManagement ui API get DataSourceSelector Signed-off-by: Zhongnan Su <szhongna@amazon.com> * Changeset file for PR #6544 created/updated --------- Signed-off-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 36a91dd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…i API to get DataSourceSelector (#6544) (#6556) * Refactor saved object management plugin to use datasourceManagement ui API get DataSourceSelector * Changeset file for PR #6544 created/updated --------- (cherry picked from commit 36a91dd) Signed-off-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…i API to get DataSourceSelector (opensearch-project#6544) * Refactor saved object management plugin to use datasourceManagement ui API get DataSourceSelector Signed-off-by: Zhongnan Su <szhongna@amazon.com> * Changeset file for PR opensearch-project#6544 created/updated --------- Signed-off-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the distinguished-contributor label Apr 18, 2024

github-actions bot added the failed changeset label Apr 18, 2024

zhongnansu marked this pull request as ready for review April 18, 2024 21:23

zhongnansu requested review from AMoo-Miki, BionIT, Flyingliuhub, SuZhou-Joe, ZilongX, abbyhu2000, ananzh, ashwin-pc, bandinib-amzn, curq, joshuarrrr, kavilla, manasvinibs, ruanyl, xinruiba and zengyan-amazon as code owners April 18, 2024 21:23

zhongnansu added the multiple datasource multiple datasource project label Apr 18, 2024

opensearch-changeset-bot bot added a commit to zhongnansu/OpenSearch-Dashboards that referenced this pull request Apr 18, 2024

Changeset file for PR opensearch-project#6544 created/updated

be613c3

github-actions bot removed the failed changeset label Apr 18, 2024

zhongnansu added backport 2.x v2.14.0 labels Apr 18, 2024

zhyuanqi reviewed Apr 18, 2024

View reviewed changes

...ugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx Show resolved Hide resolved

zhyuanqi approved these changes Apr 18, 2024

View reviewed changes

zhongnansu and others added 2 commits April 19, 2024 01:49

Refactor saved object management plugin to use datasourceManagement u…

0e4dea3

…i API get DataSourceSelector Signed-off-by: Zhongnan Su <szhongna@amazon.com>

Changeset file for PR opensearch-project#6544 created/updated

da174e4

zhongnansu force-pushed the md-refactor-saved-obejct-management branch from be613c3 to da174e4 Compare April 19, 2024 08:49

BionIT approved these changes Apr 19, 2024

View reviewed changes

ZilongX approved these changes Apr 19, 2024

View reviewed changes

ZilongX merged commit 36a91dd into opensearch-project:main Apr 19, 2024

opensearch-trigger-bot bot mentioned this pull request Apr 19, 2024

[Backport 2.x] Refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector #6556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector#6544

Refactor saved object management plugin to use datasourceManagement ui API to get DataSourceSelector#6544
ZilongX merged 2 commits intoopensearch-project:mainfrom
zhongnansu:md-refactor-saved-obejct-management

zhongnansu commented Apr 18, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Apr 18, 2024

Uh oh!

github-actions bot commented Apr 18, 2024

Uh oh!

github-actions bot commented Apr 18, 2024

Uh oh!

github-actions bot commented Apr 18, 2024

Uh oh!

github-actions bot commented Apr 18, 2024

Uh oh!

zhyuanqi Apr 18, 2024

Uh oh!

zhongnansu Apr 18, 2024

Uh oh!

zhyuanqi Apr 18, 2024

Uh oh!

Uh oh!

BionIT commented Apr 19, 2024

Uh oh!

zhongnansu commented Apr 19, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zhongnansu commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

Uh oh!

github-actions bot commented Apr 18, 2024

❌ Empty Changelog Section

Uh oh!

github-actions bot commented Apr 18, 2024

❌ Invalid Prefix

Uh oh!

github-actions bot commented Apr 18, 2024

❌ Invalid Prefix

Uh oh!

github-actions bot commented Apr 18, 2024

❌ Invalid Prefix

Uh oh!

github-actions bot commented Apr 18, 2024

❌ Invalid Prefix

Uh oh!

zhyuanqi Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

zhongnansu Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

zhyuanqi Apr 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BionIT commented Apr 19, 2024

Uh oh!

zhongnansu commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zhongnansu commented Apr 18, 2024 •

edited

Loading

zhongnansu commented Apr 19, 2024 •

edited

Loading