[Workspace] Support getting workspace client from coreStart#7501
Merged
ruanyl merged 13 commits intoopensearch-project:mainfrom Aug 16, 2024
Merged
[Workspace] Support getting workspace client from coreStart#7501ruanyl merged 13 commits intoopensearch-project:mainfrom
ruanyl merged 13 commits intoopensearch-project:mainfrom
Conversation
d2320cd to
7566a22
Compare
opensearch-changeset-bot bot
added a commit
to yubonluo/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
862494c to
df7f4e9
Compare
Signed-off-by: yubonluo <yubonluo@amazon.com>
…OpenSearch-Dashboards into 2.17-optimize-workspace-client
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7501 +/- ##
=======================================
Coverage 63.81% 63.81%
=======================================
Files 3651 3650 -1
Lines 80954 80966 +12
Branches 12893 12894 +1
=======================================
+ Hits 51662 51671 +9
- Misses 26126 26127 +1
- Partials 3166 3168 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
ruanyl
reviewed
Jul 29, 2024
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
…OpenSearch-Dashboards into 2.17/optimize-workspace-client
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
previously approved these changes
Aug 15, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
ruanyl
approved these changes
Aug 16, 2024
SuZhou-Joe
approved these changes
Aug 16, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7501-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ae7cfa6072957ac2068807618a02804321731c2f
# Push it to GitHub
git push --set-upstream origin backport/backport-7501-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 20, 2024
…ch-project#7501) * Support to get workspace client from coreStart Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR opensearch-project#7501 created/updated * Support to get workspace client from coreStart Signed-off-by: yubonluo <yubonluo@amazon.com> * fix test error Signed-off-by: yubonluo <yubonluo@amazon.com> * delete irrelevant modification Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Support to get workspace client from coreStart Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7501 created/updated * Support to get workspace client from coreStart Signed-off-by: yubonluo <yubonluo@amazon.com> * fix test error Signed-off-by: yubonluo <yubonluo@amazon.com> * delete irrelevant modification Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit ae7cfa6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 22, 2024
…7797) * Support to get workspace client from coreStart * Changeset file for PR #7501 created/updated * Support to get workspace client from coreStart * fix test error * delete irrelevant modification * optimize the code * optimize the code * optimize the code --------- (cherry picked from commit ae7cfa6) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support getting workspace client from coreStart.
Expose a workspace client interface, which can be implemented by the workspace client:
Other plugins can get workspace client from coreStart:
Currently, this interface exposes a copy method, which can be used by other plugin:
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration