fix: correct size of dashboard panel options icon button#7812
Merged
virajsanghvi merged 2 commits intoopensearch-project:mainfrom Aug 23, 2024
Merged
fix: correct size of dashboard panel options icon button#7812virajsanghvi merged 2 commits intoopensearch-project:mainfrom
virajsanghvi merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7812 +/- ##
=======================================
Coverage 63.81% 63.82%
=======================================
Files 3656 3658 +2
Lines 81205 81268 +63
Branches 12949 12964 +15
=======================================
+ Hits 51823 51869 +46
- Misses 26202 26218 +16
- Partials 3180 3181 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
virajsanghvi
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
ashwin-pc,
bandinib-amzn,
curq,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
AMoo-Miki
approved these changes
Aug 23, 2024
zhongnansu
approved these changes
Aug 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix: correct size of dashboard panel options icon button --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e62d303) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 26, 2024
* fix: correct size of dashboard panel options icon button --------- (cherry picked from commit e62d303) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts back to an xs icon button for dashboard panel options.
Issues Resolved
N/A
Screenshot
Before
After
Testing the changes
tested locally
Changelog
Check List
yarn test:jestyarn test:jest_integration