Fix issue when bootstrapping on 2.x#7901
Conversation
Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7901 +/- ##
==========================================
+ Coverage 64.21% 64.30% +0.09%
==========================================
Files 3673 3673
Lines 81185 81126 -59
Branches 12943 12928 -15
==========================================
+ Hits 52130 52171 +41
+ Misses 25847 25744 -103
- Partials 3208 3211 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@huyaboo will this fixed OSD start issue? Try to build a distribution and start OSD, it reports error as below |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7901-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 07504f6b8bfa7fe7389849b16f6f9aa6a0de87be
# Push it to GitHub
git push --set-upstream origin backport/backport-7901-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
No, but #7922 does |
* Add dynamic config service to core Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add opensearch client implementation Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add descriptions for the DAO clients Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Refactor DynamicConfigService Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Refactor dynamic config service start Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> --------- Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> (cherry picked from commit 8a96664) Fix issue when bootstrapping on 2.x (opensearch-project#7901) * Fix issue bootstrapping dynamic config service Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Changeset file for PR opensearch-project#7901 created/updated --------- Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 07504f6) Fix mock import (opensearch-project#7922) Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> (cherry picked from commit b370871)
* Add dynamic config service to core Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add opensearch client implementation Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Add descriptions for the DAO clients Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Refactor DynamicConfigService Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Refactor dynamic config service start Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> --------- Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> (cherry picked from commit 8a96664) Fix issue when bootstrapping on 2.x (#7901) * Fix issue bootstrapping dynamic config service Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> * Changeset file for PR #7901 created/updated --------- Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 07504f6) Fix mock import (#7922) Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com> (cherry picked from commit b370871) Signed-off-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
Description
Fixes bootstrap within
2.xbranch caused by #7194 . This is due to@opensearch-project/opensearchmajor version difference betweenmainand2.x, which has interface changes that break bootstrap (#3464).Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration