[Workspace]Hide saved object import button when user is outside workspace#7989
Merged
ruanyl merged 2 commits intoopensearch-project:mainfrom Sep 5, 2024
Merged
Conversation
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
approved these changes
Sep 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7989 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 3691 3691
Lines 87310 87313 +3
Branches 13433 13436 +3
=======================================
+ Hits 53340 53343 +3
Misses 30722 30722
Partials 3248 3248
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Sep 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…pace (#7989) * Hide saved object import button when user is outside workpace Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7989 created/updated --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 35be041) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 5, 2024
…pace (#7989) (#8014) * Hide saved object import button when user is outside workpace * Changeset file for PR #7989 created/updated --------- (cherry picked from commit 35be041) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
…pace (#7989) (#8014) * Hide saved object import button when user is outside workpace * Changeset file for PR #7989 created/updated --------- (cherry picked from commit 35be041) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 81ccf48) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 6, 2024
…pace (#7989) (#8014) (#8041) * Hide saved object import button when user is outside workpace * Changeset file for PR #7989 created/updated --------- (cherry picked from commit 35be041) (cherry picked from commit 81ccf48) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hide saved object import button in the save object management page(assets page)when user is outside workspace.
Issues Resolved
Related issue #4944
Screenshot
outside workspace


inside a workspace
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration