Update to latest spec while fixing workflows#1066
Open
harshavamsi wants to merge 9 commits intoopensearch-project:mainfrom
Open
Update to latest spec while fixing workflows#1066harshavamsi wants to merge 9 commits intoopensearch-project:mainfrom
harshavamsi wants to merge 9 commits intoopensearch-project:mainfrom
Conversation
…-11-09) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
requested review from
AMoo-Miki,
VachaShah,
ananzh,
kavilla,
nhtruong and
timursaurus
as code owners
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
- Add tests for giveAwsCredentialProviderLoader error paths - Covers SDK not found and provider credential errors - Improves coverage for lib/aws/shared.js error handling Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Collaborator
Author
|
@nhtruong could use your help here to review this PR. We haven't released a version of the js client in a while |
Collaborator
Author
|
@timursaurus are you available to review these changes |
Member
|
Seeing this error in CI's |
Collaborator
Author
|
@prudhvigodithi the problem here is that the runner is using a cached build, let me show up a build where it passes |
Collaborator
Author
|
Actually let me re-run the workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.