MON-4028: Add Metric server config by marioferh · Pull Request #2322 · openshift/api

marioferh · 2025-05-15T14:04:47Z

First PR: #1929
Related: Enhancements Proposal openshift/enhancements#1627

openshift-ci · 2025-05-15T14:05:08Z

Hello @marioferh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

config/v1alpha1/types_cluster_monitoring.go

marioferh · 2025-07-16T16:46:49Z

@everettraven hi, updated, aligned https://github.com/openshift/api/pull/2148/files

marioferh · 2025-07-21T09:33:05Z

/retest-required

marioferh · 2025-07-21T18:47:58Z

/test e2e-aws-ovn-hypershift-conformance

config/v1alpha1/types_cluster_monitoring.go

config/v1alpha1/tests/clustermonitoring.config.openshift.io/ClusterMonitoringConfig.yaml

marioferh · 2025-08-27T10:28:37Z

/retest-required

everettraven · 2025-08-27T14:38:08Z

verify-crd-schema check is failing on a false positive. We can safely override this.

The API looks good to me, but we have a lint failure that needs to be resolved.

marioferh · 2025-08-27T16:01:14Z

verify-crd-schema check is failing on a false positive. We can safely override this.

The API looks good to me, but we have a lint failure that needs to be resolved.

not sure why I have different issues with linter in local and in the CI, maybe different scripts?

marioferh · 2025-08-28T07:55:55Z

/retest-required

JoelSpeed · 2025-08-28T09:15:00Z

not sure why I have different issues with linter in local and in the CI, maybe different scripts?

Make sure you've rebase, make sure your code is checked out under $GOPATH/src/github.com/openshift/api, run make -c tools clean and then run the scripts again

everettraven · 2025-08-29T15:08:38Z

/approve
/lgtm

Overriding verify-crd-schema as it is failing on a false positive
/override ci/prow/verify-crd-schema

openshift-ci · 2025-08-29T15:10:50Z

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema

Details

In response to this:

/approve
/lgtm

Overriding verify-crd-schema as it is failing on a false positive
/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

marioferh · 2025-09-01T07:34:06Z

/retest-required

marioferh · 2025-09-01T07:44:19Z

/test e2e-gcp

JoelSpeed · 2025-09-01T11:16:27Z

/override ci/prow/e2e-aws-serial-2of2

Single test failure is definitely not related to this change

/hold until branching has happened tomorrow AM

openshift-ci · 2025-09-01T11:17:05Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial-2of2

Details

In response to this:

/override ci/prow/e2e-aws-serial-2of2

Single test failure is definitely not related to this change

/hold until branching has happened tomorrow AM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

config/v1alpha1/tests/clustermonitoring.config.openshift.io/ClusterMonitoringConfig.yaml

marioferh

needs /lgtm and skip again

config/v1alpha1/tests/clustermonitoring.config.openshift.io/ClusterMonitoringConfig.yaml

Signed-off-by: Mario Fernandez <mariofer@redhat.com>

JoelSpeed · 2025-09-01T13:25:37Z

/approve
/lgtm

Overriding verify-crd-schema as it is failing on a false positive
/override ci/prow/verify-crd-schema

openshift-ci · 2025-09-01T13:26:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed,everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-09-01T13:26:10Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

Details

In response to this:

/approve
/lgtm

Overriding verify-crd-schema as it is failing on a false positive
/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

everettraven · 2025-09-03T17:12:35Z

/tide refresh

JoelSpeed · 2025-09-04T10:44:55Z

/retest-required

@marioferh How would you like to handle the verified label on this PR?

JoelSpeed · 2025-09-08T08:26:31Z

/hold cancel

Branching happened last week

/retest-required

everettraven · 2025-09-08T20:11:06Z

/retest-required

everettraven · 2025-09-08T20:12:05Z

@marioferh now that the verified label is required, how would you like to get this change verified?

everettraven · 2025-09-09T12:45:41Z

Looks like this is failing on the unrelated commatrix issue that Joel brought up to TRT and is going to be addressed as a separate bug.

Overriding.

/override ci/prow/e2e-aws-serial-2of2

openshift-ci · 2025-09-09T12:46:05Z

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/e2e-aws-serial-2of2

Details

In response to this:

Looks like this is failing on the unrelated commatrix issue that Joel brought up to TRT and is going to be addressed as a separate bug.

Overriding.

/override ci/prow/e2e-aws-serial-2of2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

juzhao · 2025-09-15T11:13:19Z

/verified by @juzhao

openshift-ci-robot · 2025-09-15T11:13:31Z

@juzhao: This PR has been marked as verified by @juzhao.

Details

In response to this:

/verified by @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-09-15T15:14:56Z

@marioferh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 15, 2025

openshift-ci bot requested review from JoelSpeed and deads2k May 15, 2025 14:08

marioferh force-pushed the metrics_server_config_monitoring_api branch from 8592b9b to 4a25999 Compare May 15, 2025 15:39

everettraven reviewed May 21, 2025

View reviewed changes

marioferh force-pushed the metrics_server_config_monitoring_api branch from 4a25999 to d2369a1 Compare July 16, 2025 16:45

marioferh force-pushed the metrics_server_config_monitoring_api branch from d2369a1 to c38a1eb Compare July 16, 2025 16:47

everettraven reviewed Jul 22, 2025

View reviewed changes

config/v1alpha1/types_cluster_monitoring.go Outdated Show resolved Hide resolved

config/v1alpha1/types_cluster_monitoring.go Outdated Show resolved Hide resolved

everettraven reviewed Aug 5, 2025

View reviewed changes

everettraven requested changes Aug 19, 2025

View reviewed changes

marioferh force-pushed the metrics_server_config_monitoring_api branch from f88b3e5 to 6dfbbf6 Compare August 27, 2025 13:55

marioferh force-pushed the metrics_server_config_monitoring_api branch from 928d99d to 557334f Compare August 29, 2025 08:33

marioferh mentioned this pull request Aug 29, 2025

MON-4029: Add KubeStateMetrics api #2461

Closed

openshift-ci bot assigned everettraven Aug 29, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2025

JoelSpeed reviewed Sep 1, 2025

View reviewed changes

config/v1alpha1/tests/clustermonitoring.config.openshift.io/ClusterMonitoringConfig.yaml Outdated Show resolved Hide resolved

marioferh force-pushed the metrics_server_config_monitoring_api branch from 557334f to 269309e Compare September 1, 2025 12:53

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025

marioferh commented Sep 1, 2025

View reviewed changes

JoelSpeed reviewed Sep 1, 2025

View reviewed changes

config/v1alpha1/tests/clustermonitoring.config.openshift.io/ClusterMonitoringConfig.yaml Outdated Show resolved Hide resolved

Add metric server API

881674e

Signed-off-by: Mario Fernandez <mariofer@redhat.com>

marioferh force-pushed the metrics_server_config_monitoring_api branch from 269309e to 881674e Compare September 1, 2025 13:04

openshift-ci bot assigned JoelSpeed Sep 1, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2025

openshift-merge-bot bot merged commit 94481d7 into openshift:master Sep 15, 2025
27 checks passed

marioferh changed the title ~~Monitoring API: Add Metric server config~~ MON-4028: Add Metric server config Sep 23, 2025

Conversation

marioferh commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented May 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioferh commented Jul 16, 2025

Uh oh!

marioferh commented Jul 21, 2025

Uh oh!

marioferh commented Jul 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioferh commented Aug 27, 2025

Uh oh!

everettraven commented Aug 27, 2025

Uh oh!

marioferh commented Aug 27, 2025

Uh oh!

marioferh commented Aug 28, 2025

Uh oh!

JoelSpeed commented Aug 28, 2025

Uh oh!

everettraven commented Aug 29, 2025

Uh oh!

openshift-ci bot commented Aug 29, 2025

Uh oh!

marioferh commented Sep 1, 2025

Uh oh!

marioferh commented Sep 1, 2025

Uh oh!

JoelSpeed commented Sep 1, 2025

Uh oh!

openshift-ci bot commented Sep 1, 2025

Uh oh!

Uh oh!

marioferh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoelSpeed commented Sep 1, 2025

Uh oh!

openshift-ci bot commented Sep 1, 2025

Uh oh!

openshift-ci bot commented Sep 1, 2025

Uh oh!

everettraven commented Sep 3, 2025

Uh oh!

JoelSpeed commented Sep 4, 2025

Uh oh!

JoelSpeed commented Sep 8, 2025

marioferh commented May 15, 2025 •

edited

Loading

marioferh left a comment •

edited

Loading