OCPNODE-3121: Make FeatureGateImageVolume TechPreview#2403
OCPNODE-3121: Make FeatureGateImageVolume TechPreview#2403openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@bitoku: This pull request references OCPNODE-3121 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @bitoku! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XS
bitoku
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Since this is an upstream gate, can you confirm the lifecycle of the gate? When did it get enabled by default in upstream? |
|
@JoelSpeed It's beta and disabled by default right now. However, our team decided to graduate this feature to GA in 4.20.
|
|
I think the first step of getting this feature promoted to GA would be to get it enabled and running in CI in TechPreview clusters. This will allow us to see how it behaves in OpenShift and I assume, run upstream E2E tests to build a baseline for feature regression. Can we start with tech preview? Also, you'll need to run the |
bitoku
changed the title
openshift-ci
bot
added
size/S
bitoku
changed the title
|
@bitoku: This pull request references OCPNODE-3121 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
JoelSpeed
left a comment
JoelSpeed
left a comment
There was a problem hiding this comment.
/approve
/assign @haircommander
Peter, are you happy with the plan suggested above of enabling this in TP and gathering test data before we promote?
Also, wanted to check you're ok with the gate being tagged to your handle?
openshift-ci
bot
added
the
approved
|
I put Peter because https://github.com/openshift/api?tab=readme-ov-file#adding-new-techpreview-featuregate-to-all-clusterprofiles-hypershift-and-selfmanaged says "my-team-lead". |
You mean make it TechPreview internally and then once we run enough CI to graduate, make it GA for 4.20, right? |
|
TP to gather feedback works for me /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitoku, haircommander, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest-required |
3 similar comments
|
/override ci/prow/minor-e2e-upgrade-minor Known issue with KAS on upgrades at the moment /test e2e-aws-serial-techpreview-2of2 |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/minor-e2e-upgrade-minor DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-serial-techpreview-2of2 |
|
/override ci/prow/minor-e2e-upgrade-minor |
|
@saschagrunert: saschagrunert unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/minor-e2e-upgrade-minor |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/minor-e2e-upgrade-minor DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Revision affbfc1 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-aws-serial-techpreview-1of2 Test failures seem not related. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
@bitoku: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
6 participants
This PR graduates ImageVolume featuregate to TechPreview.
upstream:
downstream: