Skip to content

OCPNODE-3863: Add CRIOCredentialProviderConfig API#2557

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
QiWang19:creds-provider
Feb 4, 2026
Merged

OCPNODE-3863: Add CRIOCredentialProviderConfig API#2557
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
QiWang19:creds-provider

Conversation

@QiWang19
Copy link
Copy Markdown
Member

@QiWang19 QiWang19 commented Nov 1, 2025 •
edited
Loading

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 1, 2025

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 1, 2025
@QiWang19 QiWang19 changed the title Add CRIOCredentialProviderConfig API and related functionality Add CRIOCredentialProviderConfig API Nov 1, 2025
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Nov 1, 2025

/retest-required

@QiWang19 QiWang19 force-pushed the creds-provider branch 2 times, most recently from 8805169 to 108219f Compare November 3, 2025 22:49
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Nov 3, 2025

/test integration

@QiWang19 QiWang19 marked this pull request as ready for review November 3, 2025 23:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Nov 3, 2025

PR has been reviewed by claude code /api-review. It helped run make lint and correct the failures.

QiWang19
QiWang19 commented Nov 3, 2025
View reviewed changes
saschagrunert
saschagrunert reviewed Nov 4, 2025
View reviewed changes
@QiWang19 QiWang19 force-pushed the creds-provider branch 2 times, most recently from d2a191b to 41bd600 Compare November 4, 2025 20:10
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2025
@QiWang19 QiWang19 changed the title Add CRIOCredentialProviderConfig API OCPNODE-3863: Add CRIOCredentialProviderConfig API Nov 4, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-3863 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-3863 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

saschagrunert
saschagrunert reviewed Nov 5, 2025
View reviewed changes
saschagrunert
saschagrunert approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, otherwise LGTM

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Nov 12, 2025

/assign @everettraven

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2026

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2026

/retest-required

Remaining retests: 0 against base HEAD c16ec2b and 2 for PR HEAD e73ed72 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 30, 2026

/retest-required

Remaining retests: 0 against base HEAD 71e91db and 1 for PR HEAD e73ed72 in total

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Jan 30, 2026

/retest-required

1 similar comment
@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 2, 2026

/retest-required

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 2, 2026

/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Feb 2, 2026 •
edited
Loading

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 2, 2026

/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Feb 2, 2026 •
edited
Loading

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

@everettraven
Copy link
Copy Markdown
Contributor

everettraven commented Feb 2, 2026

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-serial-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 2, 2026

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/e2e-aws-serial, ci/prow/e2e-aws-serial-techpreview

Details

In response to this:

/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-aws-serial-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 2, 2026

/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Feb 2, 2026 •
edited
Loading

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 3, 2026

/test e2e-aws-serial-1of2

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Feb 3, 2026 •
edited
Loading

PR-Agent: could not fine a component named e2e-aws-serial-1of2 in a supported language in this PR.

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Feb 3, 2026

/retest

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 3, 2026

/retest-required

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 3, 2026

/test images

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Feb 3, 2026 •
edited
Loading

PR-Agent: could not fine a component named images in a supported language in this PR.

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 3, 2026

/test minor-e2e-upgrade-minor

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Feb 3, 2026 •
edited
Loading

PR-Agent: could not fine a component named minor-e2e-upgrade-minor in a supported language in this PR.

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 3, 2026

/test minor-images

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review bot commented Feb 3, 2026 •
edited
Loading

PR-Agent: could not fine a component named minor-images in a supported language in this PR.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 3, 2026

/retest-required

Remaining retests: 0 against base HEAD 6186972 and 0 for PR HEAD e73ed72 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 3, 2026

/hold

Revision e73ed72 was retested 3 times: holding

@QiWang19
Copy link
Copy Markdown
Member Author

QiWang19 commented Feb 3, 2026

/hold cancel

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 3, 2026

/retest-required

Remaining retests: 0 against base HEAD 6186972 and 2 for PR HEAD e73ed72 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 3, 2026 •
edited
Loading

@QiWang19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn cc9c041 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 4, 2026

/retest-required

Remaining retests: 0 against base HEAD e09e5a4 and 1 for PR HEAD e73ed72 in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@everettraven everettraven Awaiting requested review from everettraven

+1 more reviewer

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@QiWang19 @openshift-ci-robot @JoelSpeed @saschagrunert @everettraven @openshift-merge-robot